75447 - alt-3pane, many accelerators are not displaying (i.e.Ctrl+W)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Ninoschka Baca]

Build 2001-04-09-04: NT4
Build 2001-04-10-04: Mac 9.04
Haven't checked linux

Overview: Many of the accelerators are not appearing in the menus using the 
alt-3pane. Since there are so many missing I'll list the following just for an 
example:

- File, Ctrl+W
- Edit, Ctrl+C, Ctrl+V
- Search, Ctrl+F
- Go, Next, N for next unread
- Message, Ctrl+R

Additional Information:
- Try and use the accelerators and they do not work. I'll log a seperate bug.

Comment 1

[Ninoschka Baca]

I'm not sure when this started. The problem existed in 
Build 2001-04-06-08: NT4, Mac 9.04.

Comment 2

[scottputterman]

reassigning to ssu.

Comment 3

[Ninoschka Baca]

Interesting that some accelerators appear such as the File menu
displays Ctrl+M.

Comment 4

[scottputterman]

I looked at the xul and it looks like messenger.xul brings in keyset
id="mailKeys" and commandset id="mailCommands", but
mail3PaneWindowVertLayout.xul does not.

Comment 5

[Blake Ross]

Attachment: [patch] fix accelerators in 3-pane layout

Comment 6

[Blake Ross]

The attached patch also fixes another bug where the Tasks menuitems didn't work 
in the other layout. seth, sr?

Comment 7

[Sean Su]

The tasks menu item not working is bug 75038.  There's already a patch attached 
to that bug awaiting r=,sr=.

Comment 8

[(not reading, please use [e-mail] instead)]

I've given ssu a sr=sspitzer on #75038, so if he land before you'll get conflicts.

ssu, can you review / test blake's patch?  

I'll be quick with the super review turn around.

Comment 9

[Sean Su]

The patch fixes this bug, bug 75038, and bug 75453.  r=ssu

Comment 10

[Blake Ross]

Sean, feel free to checkin the fix for 75038...it's a different file anyways, 
so it won't conflict.

Comment 11

[Sean Su]

your patch covers two files:
 mailnews/base/resources/content/mail3PaneWindowVertLayout.xul
 mailnews/base/resources/content/messenger.xul

my patch to bug 75038 covers one file:
 mailnews/base/resources/content/messenger.xul

which is the same exact fix you have.  I'll be marking bug 75038 fixed once you 
check this patch in.

Comment 12

[(not reading, please use [e-mail] instead)]

sr=sspitzer

thanks guys.

Comment 13

[Blake Ross]

Sean, my point was that the fix in messenger.xul was tangential -- something I 
just happened to notice while doing this fix -- and completely unnecessary to 
fix this bug.  But anyways, fix checked in (all of it).

Comment 14

[Ninoschka Baca]

Build 2001-04-17-04: NT4, Mac 9.04
Build 2001-04-17-08: Linux RH 6.2
Verified Fixed.