Developer Tools should have a toolbar menubutton for easy access

RESOLVED WORKSFORME

Status

DevTools
General
RESOLVED WORKSFORME
6 years ago
a month ago

People

(Reporter: Felipe, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

(Reporter)

Description

6 years ago
Accessing the developer tools right now takes 1 too many clicks, and also my brain melts when I switch between Win/Mac and forget about the different menu placement of the two platforms.

I believe web developers would like the easy of access by having them placed in a toolbar dropdown menu, like some of the traditional developer tools add-ons used to the in the past.

Thoughts? I've even got the patch ready ;) And a screenshot.  We'd just need to create a proper icon for it (which might be easier said than done, as I'm not sure if we have an icon at the moment that represents our developer tools).
(Reporter)

Comment 2

6 years ago
Created attachment 623336 [details]
Screenshot

Screenshot, using a temporary icon
(Reporter)

Comment 3

6 years ago
Forgot to mention, but it should be obvious, that the button won't be there by default. But it will be available at the toolbar customization palette for whoever wants to grab it and drop at the toolbar.

Comment 4

6 years ago
Comment on attachment 623335 [details] [diff] [review]
Patch

Felipe, we are working on a dedicated toolbar. But I don't think an additional button would be too much. I like it :)
Attachment #623335 - Flags: feedback+
I'm wondering if that isn't going to be giving users too many options to choose from. Do we want to hide this button dynamically if the global toolbar is enabled?

There's also the notion of some button palettes for australis, but have no idea when that's arriving. Wondering if we shouldn't wait for that rather than adding toolbar buttons now?

Comment 6

6 years ago
(In reply to Rob Campbell [:rc] (:robcee) from comment #5)
> I'm wondering if that isn't going to be giving users too many options to
> choose from.

This is hardly a paralyzing choice.  You only find it from a panel you only open if you're actively looking around for as many options as possible.

> Do we want to hide this button dynamically if the global
> toolbar is enabled?

The global toolbar isn't really a complete replacement for the web development toolbar.  The web developer menu is added to by various addons etc. that might not show up on the web dev toolbar, and there are a few other options (error console, view source) that I don't imagine we'll be putting on the web developer toolbar either.

We don't hide the web developer menu by default when the global toolbar is enabled, I wouldn't see a reason to hide quick access to it either.

But yeah, if australis is going to kill customizable toolbars then maybe we don't want to give people something nice that we'll have to take away.

Comment 7

6 years ago
(In reply to Dave Camp (:dcamp) from comment #6)

> 
> The global toolbar isn't really a complete replacement for the web
> development toolbar.  The web developer menu is added to by various addons

Err, I meant "for the web developer menu"
Comment on attachment 623335 [details] [diff] [review]
Patch

+function buildDevToolsToolbarMenu(target) {
+  if (target._menuPopulated)
+    return;
+
+  let reference = document.getElementById("menuWebDeveloperPopup");
+
+  for (let item of reference.childNodes) {
+    let copy = item.cloneNode();
+    target.appendChild(copy);
+  }
+
+  target._menuPopulated = true;
+}
+

This can clone nodes but doesn't take into account their checked states. If a user drags the web developer button into the toolbar, checked states will be representative of when the drag happened, i.e., you could have a checked Inspector menu item in this list that doesn't get updated when the Inspector is deactivated.
Attachment #623335 - Flags: feedback-
dcamp: I agree that this might be useful and convenient. After thinking about it, it's nice being able to put things on the main toolbar.

I'm a little worried about how we're going to deal with menuitem check states in all of these various bits of UI though.
(Reporter)

Comment 10

6 years ago
Rob, I thought that at first too, but turns out the checked states work properly. Turns out the checked state is set on the <command> and not on the menuitems, so all the menus properly reflect it at the same time.
Comment on attachment 623335 [details] [diff] [review]
Patch

Hm, ok. One other question: You're cloning the ids of these menuitems as well? That could be a problem.
(Reporter)

Comment 12

6 years ago
oh yeah right, I need to handle that
(Reporter)

Updated

6 years ago
Attachment #623336 - Flags: ui-review?(limi)
Comment on attachment 623335 [details] [diff] [review]
Patch

f+ with the duplicate ids taken care of.
Attachment #623335 - Flags: feedback- → feedback+
(Reporter)

Comment 14

6 years ago
I will need icons to proceed here!

Updated

6 years ago
Blocks: 763932

Updated

6 years ago
No longer blocks: 763932

Comment 15

6 years ago
In the toolbar button, I see:
> onpopupshowing="onWebDeveloperMenuShowing()"

I don't think this is needed.

Also, we designed an icon: https://bug760446.bugzilla.mozilla.org/attachment.cgi?id=636696
It will be available once bug 764555 is fixed.

Updated

6 years ago
Depends on: 765564

Comment 17

6 years ago
Created attachment 642649 [details]
screenshot

we need specific icons

Comment 18

6 years ago
Stephen, can you help for the icons?
(Reporter)

Comment 19

6 years ago
Comment on attachment 623336 [details]
Screenshot

Pretty sure I talked to Limi about this some time ago and he was fine with the idea as long as it goes into the customization palette and not on the toolbar by default
Attachment #623336 - Flags: ui-review?(limi)

Comment 22

6 years ago
Created attachment 657842 [details]
linux 24

Comment 23

6 years ago
Created attachment 657843 [details]
linux 16
Bump.

Comment 25

5 years ago
This has been fixed in Australis.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.