754504 - Firefox 13: session restore ignores "sessionstore.js"

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[XICO2KX]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0
Build ID: 20120509070325

Steps to reproduce:

I updated some plugins, but did not restart, just hit the close button.
Later (after a long time) I noticed that the Firefox process was still running (although no windows were visible) and I terminated it.


Actual results:

When I opened Firefox again, my tabs were gone!

The list in "about:sessionrestore" was also empty.
I tried replacing "sessionstore.js" with "sessionstore.bak" and restarting, but still nothing.
I thought the file could be corrupted, but I opened it in a JSON parser and it says it is well-formed.
The "Error Console" showed no errors.


Expected results:

The tabs should have been correctly restored!

Comment 1

[XICO2KX]

Additional details follow.

User agent string: "Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0"
"Show my windows and tabs from last time" is enabled.
"browser.sessionstore.max_resumed_crashes" set to 1.

Any fix on this?

Comment 2

[XICO2KX]

Attachment: comparing both valid and invalid sessionstore.js

This image shows the major differences between the the valid (newly created) "sessionstore.js" and the invalid (not loaded) old "sessionstore.bak".

Comment 3

[XICO2KX]

Ok, I found the bug!!!
For some reason (maybe because I closed FF, and *not restarted when asked*, after updating plugins) all the tabs were written under "_closedWindows" and not "windows".
(please check attached image)

I renamed the "_closedWindows" entry to "windows", replaced "sessionstore.js" with the fixed "sessionstore.bak", started Firefox, and my tabs were all back!!!

So, in fact, it was not Firefox that was ignoring the "sessionstore.js" file, as I wrote in the bug description, but the tabs were saved in the wrong section of the file.

Nevertheless, a bug is still there, and it would be nice if someone could fix it.
Thank you very much!

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Thanks for debugging the issue and following up!

There are a few issues related to window close order. In this case it sounds like you closed all the windows and there was an update window behind them, so we didn't do the expected thing. I'm 95% sure we have that bug on file at least once so I'm going to close this out as invalid (as filed).