754658 - Monochrome icons for lightning-button-calendar and lightning-button-tasks

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

The two buttons for the main toolbar are still colored and not monochrome like the other buttons.

Comment 1

[Richard Marti (:Paenglab)]

Andreas, please can you create monochrome icons for mode-switch-icons-aero.png?

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Image file with OSX icons as proposal

Andreas, i attached the file needing the new monochrome icons. This image has the OSX icons to show where the new icons should stay.

Please can you create the needing icons?

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Inverted icons eventually needing a update

Attached is the inverted icon eventually needing a update (see following attachment)

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Screenshot showing the differences

Andreas, if you use the same glyphs as OSX then should the inverted icons be updated to match the normal ones?
Also the Calendar tab icon does not match the button glyph. If you want to change it also it is the icon directly below the new icons in mode-switch-icons-aero.png

Comment 5

[Andreas Nilsson (:andreasn)]

Ah, now I see what you mean. New graphics coming up!

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: new mode switch inverted icons

Looks good?

Comment 7

[Richard Marti (:Paenglab)]

Attachment: Inverted icon with filled calendar glyph

I thought the Calendar glyph looked for me a little empty. I put a 7 in it like on the normal glyph.

Andreas, what do you say to this?

Comment 8

[Andreas Nilsson (:andreasn)]

(In reply to Richard Marti [:paenglab] from comment #7)

> I thought the Calendar glyph looked for me a little empty. I put a 7 in it
> like on the normal glyph.

Yeah, lets do that. I'll attach a version with a bit more antialias on it.

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

btw, any specific reason for 7 instead of the much more common 1 ?

Comment 10

[Andreas Nilsson (:andreasn)]

we can use 1 instead, but 7 is a good shape. Using 1 it will either have to be off-center or 2 px fat. 7 neatly avoids this.

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: mode switch icons

mode-switch-icons-aero

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: mode switch icons inverted

mode-switch-icons-inverted

Comment 13

[Richard Marti (:Paenglab)]

Attachment: patch

Patch changing the toolbarbutton icons, the "New Task" button and the "New Event" button in the today-panel.

Comment 14

[Richard Marti (:Paenglab)]

Attachment: patch in action

Patch in action for easier ui-r

Comment 15

[Andreas Nilsson (:andreasn)]

Hm, these looks really strange next to the other icons (the inverted variant looks fine though). I'll cancel the review and update them a bit and post a new patch.

Comment 16

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Andreas, any updates on the icons here?

Comment 17

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 627993 [details] [diff] [review]
patch

Codewise this looks fine, r+ on that. I guess you still need new icons, right?

Setting f?=andreasn to make sure its in his queue.

Comment 18

[Jim Porter (:squib)]

(In reply to Richard Marti [:paenglab] from comment #14)
> Created attachment 627994 [details]
> patch in action
> 
> Patch in action for easier ui-r

For consistency, I think the tab icons should remain colorful. That's how the rest of Thunderbird looks (for the time being, anyway).

Comment 19

[Richard Marti (:Paenglab)]

(In reply to Jim Porter (:squib) from comment #18)
> For consistency, I think the tab icons should remain colorful. That's how
> the rest of Thunderbird looks (for the time being, anyway).

I asked this already through IRC. Andreas replied like "The Australis mockup has also monochrome tab graphics also we are using the monochrome icons".

See: <http://25.media.tumblr.com/tumblr_m0iwtyy6nh1qkoea4o1_1280.png>

Comment 20

[Jim Porter (:squib)]

(In reply to Richard Marti [:paenglab] from comment #19)
> I asked this already through IRC. Andreas replied like "The Australis mockup
> has also monochrome tab graphics also we are using the monochrome icons".
> 
> See: <http://25.media.tumblr.com/tumblr_m0iwtyy6nh1qkoea4o1_1280.png>

I don't think that's a good move: 1) it makes the UI look inconsistent when a folder tab uses a colored icon, and 2) since the exact order of tabs can obviously vary, having some color will help people find the tab they're looking for more quickly. (The colorless toolbar buttons are fine because they're almost always in the same spot.)

Comment 21

[Andreas Nilsson (:andreasn)]

All right, lets do full color tab icons for now.

Comment 22

[Andreas Nilsson (:andreasn)]

Attachment: new mode switch icons (with colored variants)

Comment 23

[Richard Marti (:Paenglab)]

Attachment: patch v2

I'm asking Andreas for both reviews because I only changed the css to separate the button- and the tab icons.

Comment 24

[Richard Marti (:Paenglab)]

Attachment: patch in action

Screenshot with patch in action for easier review.

Comment 25

[Andreas Nilsson (:andreasn)]

Comment on attachment 632301 [details] [diff] [review]
patch v2

ui-r+ based on screenshot since my build is currently not working properly.

Comment 26

[Andreas Nilsson (:andreasn)]

Comment on attachment 632301 [details] [diff] [review]
patch v2

And code looks good too.

Comment 27

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/bbe839080d59>