754675 - Highlight whitespace changes

Status: RESOLVED INCOMPLETE

(bugzilla.mozilla.org :: Splinter, enhancement, P5)

Description

[Gordon P. Hemsley [:GPHemsley]]

As a stopgap measure until bug 654446 (or as an addition to it), it would be useful to highlight when whitespace is involved in a change. I know there are some differs that do this by changing the color of the background, which I think would be useful. I also expect it would be somewhat easier to implement than the full-fledged whitespace-excluder, and it would still go a long way towards speeding up whitespace-heavy reviews.

Comment 1

[:glob ✱]

bug 694304 is related to this request.

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

(In reply to Byron Jones ‹:glob› from comment #1)
> bug 694304 is related to this request.

I'd go so far as to say it blocks this request.

Comment 3

[Gordon P. Hemsley [:GPHemsley]]

It appears that this functionality was added at some point, at least for trailing whitespace.

Not sure if it's desired to do the same for all whitespace on a line (e.g. indentation, etc.) or whether this bug can be closed.

Comment 4

[:glob ✱]

(In reply to Gordon P. Hemsley [:gphemsley] from comment #3)
> It appears that this functionality was added at some point, at least for
> trailing whitespace.

indeed, bug 776897 implemented trailing whitespace highlighting.

> Not sure if it's desired to do the same for all whitespace on a line (e.g. indentation,
> etc.) or whether this bug can be closed.

personally i don't see value in highlighting non-trailing whitespace, but then again i didn't raise this request :)  if you feel trailing whitespace highlighting only is sufficient, feel free to WONTFIX this bug.

Comment 5

[Kohei Yoshino [:kohei]]

Splinter is retiring.