75470 - Add bookmarks dialog should remember its position

Status: VERIFIED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect, P4)

Description

[Simon Fraser [no longer active]]

The Add Bookmarks dialog should be resizable, so that you can stretch it out to 
see more of the tree. It should also remember its last size and position.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Patch to fix resizing and persistence

Comment 2

[Simon Fraser [no longer active]]

This patch does the following:
1. Fixes the openDialog flags to make the window resizable, and look more like a 
dialog.
2. Persists size and position of the window
3. Changes box flex in a couple of places so that resizing the window makes the 
tree get bigger.

Reviews, please.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

r=[e-mail]. .9, will apply to tree and check in with my other stuff. 

Comment 4

[Paul Chen]

Looks copacetic to me, too. r=pchen.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

*changes r= to sr=*

Comment 6

[Simon Fraser [no longer active]]

sr=sfraser if you like.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

booya

Comment 8

[Simon Fraser [no longer active]]

Reopening. Ben, you failed to check in this bookmarksOverlay.js part, so the 
dialog still looks weird.

Comment 9

[Paul Chen]

nav triage team:

Ben, check that file in!

Comment 10

[Fabian Guisset]

Ben today's changes haven't taken into account the dialog=yes change to
bookmarksOverlay.js. Do we still want to do that?

Comment 11

[Simon Fraser [no longer active]]

Yes we do.

Comment 12

[Simon Fraser [no longer active]]

Ben promised to fix this, the patch is in the bug.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

oy. This bug is like a turd that won't flush. Accepting. Triage team, this is
trivial, don't minus, it takes like 5 mins to fix & checkin ;) 

Comment 14

[Simon Fraser [no longer active]]

I just checked this in. I got all 3 places we bring up addBookmarks.xul.

Comment 15

[Claudius Gayle]

I hate to reopen this bug but based on Simon's opening comments when filing this bug it is
not fixed. The add/file bookmark dialog now resizes and persists its size but does not persist
its position. It resets its position to center on each occasion. I tested this by invoking it, moving
and sizing it, and cancelling it.

Comment 16

[Simon Fraser [no longer active]]

Erk.

Comment 17

[Claudius Gayle]

2001051504 builds, btw

Comment 18

[Paul Chen]

nav triage team:

Marking nsbeta1+, p4, and mozilla0.9.3

Comment 19

[Paul Chen]

nav triage team:

Not a 0.9.3 stopper, marking mozilla1.0

Comment 20

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 21

[Paul Chen]

worksforme using my debug build from this morning, marking w4m

Comment 22

[sairuh (rarely reading bugmail)]

mass-verifying WorksForMe bugs which haven't changed since 2001.12.31.

set your search string in mail to "EmperorLondoMollari" to filter out these
messages.