754795 - OSFileConstants.cpp fails to compile on mingw-w64

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

GCC considers direct 64-bit pointer to 32-bit integer as an error and that's what happens with INVALID_HANDLE_VALUE. INVALID_HANDLE_VALUE is of type HANDLE, which is void*, but guaranteed to be 32-bit value. Thus casting is fine, but needs to be done a bit differently. The attached patch changes the cast to use INT_PTR, which is later implicitly casted to 32-bit int.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 623619 [details] [diff] [review]
fix v1.0

Fine with me. I assume that you have tested that this does not prevent compilation with VC++?

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 623619 [details] [diff] [review]
fix v1.0

Review of attachment 623619 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/OSFileConstants.cpp
@@ +216,5 @@
>    INT_CONSTANT(FILE_ATTRIBUTE_READONLY),
>    INT_CONSTANT(FILE_ATTRIBUTE_TEMPORARY),
>  
>    // SetFilePointer error constant
> +  { "INVALID_HANDLE_VALUE", INT_TO_JSVAL((INT_PTR)INVALID_HANDLE_VALUE) },

This should be INT_PTR(INVALID_HANDLE_VALUE)

Comment 3

[Jacek Caban]

Thanks for the reviews. Yes, I've tested compilation with VC++. Pushed to m-i addressing Ms2ger's comment:

https://hg.mozilla.org/integration/mozilla-inbound/rev/26fd69b1eec3

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26fd69b1eec3