Closed Bug 754800 Opened 8 years ago Closed 6 years ago

Intermittent browser_aboutSyncProgress.js | leaked until shutdown [nsGlobalWindow #44 about:sync-progress]

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dao, Unassigned)

References

Details

(Keywords: intermittent-failure, memory-leak)

Attachments

(1 file)

This shows up in debug build test logs:

[browser/base/content/test/browser_aboutSyncProgress.js]
  2 window(s) [url = about:sync-progress]
OS: All → Mac OS X
This doesn't seem to happen on OS X 10.5.8.
Summary: browser_aboutSyncProgress.js leaks two about:sync-progress windows on OS X → browser_aboutSyncProgress.js leaks two about:sync-progress windows on OS X 10.6
Component: Firefox Sync: UI → Widget: Cocoa
Product: Mozilla Services → Core
QA Contact: sync-ui → cocoa
With this patch, the leaks disappear. So it looks like there's a problem with the <progress/> implementation. Since this is limited to OS X 10.6, I'm guessing it might be a widget:cocoa issue?
Also happened on:

Rev3 Fedora 12x64 mozilla-inbound debug test mochitest-other on 2012-05-21 23:37:22 PDT for push bea719080c06

slave: talos-r3-fed64-017

https://tbpl.mozilla.org/php/getParsedLog.php?id=11941078&tree=Mozilla-Inbound
Blocks: 754804
https://tbpl.mozilla.org/php/getParsedLog.php?id=12760634&tree=Mozilla-Aurora

[browser/base/content/test/browser_aboutSyncProgress.js]
  2 window(s) [url = about:sync-progress]
Bug 772388 means this needs to show up on [orange]/sw:randomorange searches; adding.
Blocks: 438871
Summary: browser_aboutSyncProgress.js leaks two about:sync-progress windows on OS X 10.6 → Intermittent leak in browser_aboutSyncProgress.js of two about:sync-progress windows
Whiteboard: [orange]
I can't help but notice all the failures are on Lion talos machines. Do we not have non-Lion talos machines or does this seem to be Lion specific? (I know nothing about Talos tests.)
(In reply to Gregory Szorc [:gps] from comment #42)
> I can't help but notice all the failures are on Lion talos machines. Do we
> not have non-Lion talos machines or does this seem to be Lion specific? (I
> know nothing about Talos tests.)

You can happily continue not to - this is a mochitest-browser-chrome issue, and the "talos-" in the slavename is mostly a historical artifact from when that class of slave, which now runs all the tests except for make check, only ran talos.

We do have non-Lion tests, the "OS X64 debug" row is 10.6. However, the way this class of failures is reported is that when it exceeds a threshold for the number of domwindows/docshells leaked until shutdown, it reports every test that leaked one, but when it does not exceed the threshold it doesn't report any as failures. So one possibility is that browser_aboutSyncProgress.js only leaks on 10.7, but another is that 10.7 sometimes exceeds the threshold, while 10.6 does not.
Hasn't shown up after bug 728294 landed, so going to call this a false positive and mark WFM for now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Ed, it appears to have shown back up. Should we re-open or is today's blip a false positive as well in your opinion?
(In reply to :Ally Naaktgeboren from comment #62)
> Ed, it appears to have shown back up. Should we re-open or is today's blip a
> false positive as well in your opinion?

No this should be reopened. Thank you for spotting! :-)
(I have TinderboxPushlog Robot mails filtered to trash otherwise the spam from filed [orange] bugs gets unmanageable... at least on gmail where you cannot filter by x-headers)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Intermittent leak in browser_aboutSyncProgress.js of two about:sync-progress windows → Intermittent browser_aboutSyncProgress.js | leaked until shutdown [nsGlobalWindow #44 about:sync-progress]
Whiteboard: [orange]
Resolving WFM keyword:intermittent-failure bugs last modified >3 months ago, whose whiteboard contains none of:
{random,disabled,marked,fuzzy,todo,fails,failing,annotated,time-bomb,leave open}

There will inevitably be some false positives; for that (and the bugspam) I apologise. Filter on orangewfm.
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.