Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Catalog sheet code is broken at least in unpackaged build

RESOLVED FIXED in Firefox 13

Status

()

Core
Networking
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Assigned: bbondy)

Tracking

({regression})

unspecified
mozilla15
x86
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(firefox13+ fixed, firefox14+ fixed, firefox15 fixed, firefox-esr1013+ fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
It's comparing stylesheet URIs, but bug 670514 changed what the stylesheet URI is in this case.

We need to make a change to nsResProtocolHandler similar to the one in bug 751905.
(Reporter)

Updated

5 years ago
tracking-firefox15: --- → ?
Keywords: regression
(Assignee)

Comment 1

5 years ago
Created attachment 623755 [details] [diff] [review]
Patch v1.

I'm not sure what the catalog sheet code is, so I didn't test, but I think this is the desired fix.
Attachment #623755 - Flags: review?(bzbarsky)
(Reporter)

Comment 2

5 years ago
Comment on attachment 623755 [details] [diff] [review]
Patch v1.

r=me.  Thanks!

You can test, if you really want to, by seeing how often the "do the load" stuff in nsDocument::EnsureCatalogSheet is hit for the same document if you load a document that does SVG stuff.  No way to write an automated test, sadly.  :(
Attachment #623755 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/3ce1f1bf0cfe
Target Milestone: --- → mozilla15

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3ce1f1bf0cfe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
tracking-firefox15: ? → -
status-firefox15: --- → fixed
tracking-firefox-esr10: --- → 13+
tracking-firefox13: --- → +
tracking-firefox14: --- → +
tracking-firefox15: - → ---
(Assignee)

Comment 5

5 years ago
Fixed for Aurora in changeset:
http://hg.mozilla.org/releases/mozilla-aurora/rev/cf5c4540fe22
See Bug 670514
status-firefox14: --- → fixed
(Assignee)

Updated

5 years ago
No longer blocks: 670514
Blocks: 670514

Updated

5 years ago
status-firefox13: --- → fixed
(Assignee)

Comment 6

5 years ago
Thanks for marking.
See Bug 670514
http://hg.mozilla.org/releases/mozilla-beta/rev/7a2c1909e205
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/mozilla-esr10/rev/8ef222645a1a
status-firefox-esr10: --- → fixed
Is there anything QA needs to do to verify this fix?
(Reporter)

Comment 9

5 years ago
No, I don't think so.  Verifying involves basically either attaching a debugger or modifying the code to measure some things...
Okay, thanks Boris. Marking this [qa-] based on that.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.