There is not a plain link to a bug (i.e. to the top of the bug) in html bugmail

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Email Notifications
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mrbball, Assigned: Koosha KM)

Tracking

Bugzilla 4.2
Bug Flags:
approval +
approval4.2 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

790 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
When only a comment is added to a bug (i.e. no fields are changed) the
html email that is generated does not contain a hyperlink to the top of
the bug (i.e. http://.../show_bug.cgi?id=XXX).

Instead, the bugmail has a link to the specific comment that was added
(i.e. http://.../show_bug.cgi?id=XXX#cYYY).

The link to the comment is not all that useful, since I already have the
text of the comment in my mailer.  I usually want to go to the top of
the bug, not the specific comment.  In general, this is annoying, but
when a bug has dozens or even hundreds of comments and the hyperlink
takes me to the bottom, it's quite sub-optimal.

I guess a link to the specific comment doesn't hurt, but there should
certainly be a link to the bug itself.

Comment 1

6 years ago
The plain text email has a link pointing to the bug itself, not its comment, but the HTML format doesn't. Not sure we will fix it for 4.2.x, though.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [Good Intro Bug]
Target Milestone: --- → Bugzilla 4.4
(Assignee)

Comment 2

6 years ago
Created attachment 624686 [details] [diff] [review]
patch - v1
Attachment #624686 - Flags: review?(LpSolit)
(Assignee)

Comment 3

6 years ago
Created attachment 624688 [details] [diff] [review]
patch - v1.0.1
Attachment #624686 - Attachment is obsolete: true
Attachment #624686 - Flags: review?(LpSolit)
Attachment #624688 - Flags: review?(LpSolit)

Comment 4

6 years ago
Comment on attachment 624688 [details] [diff] [review]
patch - v1.0.1

>+              on [% "${terms.Bug} # ${bug.id}" FILTER bug_link( bug, { full_url => 1 }) %]

"Bug" should be lowercase, and we don't want # before the bug ID. Also, |FILTER none| is required, else it doesn't pass tests.

Otherwise looks good, and I think this is a good compromise to fix this bug. r=LpSolit
Attachment #624688 - Flags: review?(LpSolit) → review+

Updated

6 years ago
Assignee: email-notifications → koosha.khajeh
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: approval+
Whiteboard: [Good Intro Bug]

Comment 5

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/bugmail.html.tmpl
Committed revision 8240.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Flags: approval4.2?

Comment 6

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified template/en/default/email/bugmail.html.tmpl
Committed revision 8089.
Flags: approval4.2? → approval4.2+
Target Milestone: Bugzilla 4.4 → Bugzilla 4.2
You need to log in before you can comment on or make changes to this bug.