755033 - Fix build warnings under dom/indexeddb/

Status: RESOLVED WORKSFORME

(Core :: Storage: IndexedDB, defect, P5)

Comment 1

[Josh Matthews [:jdm]]

Attachment: <required>

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 623810 [details] [diff] [review]
<required>

Review of attachment 623810 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not convinced that these are useful warnings to fix.

::: dom/plugins/test/testplugin/nptest.cpp
@@ +1066,5 @@
>  
>    if (instanceData->asyncDrawing == AD_BITMAP) {
>      if (instanceData->frontBuffer &&
> +        static_cast<uint32_t>(instanceData->frontBuffer->size.width) == window->width &&
> +        static_cast<uint32_t>(instanceData->frontBuffer->size.height) == window->height) {

http://www.youtube.com/watch?v=A9mZZfVJNQ0

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 623810 [details] [diff] [review]
<required>

Review of attachment 623810 [details] [diff] [review]:
-----------------------------------------------------------------

I think these are silly warnings.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

These warnings are now moot; we use tmp in IDBIndex and IDBWrapperCache is gone and this is not the right module for dom/plugins.