755049 - Fix build warnings under security/

Status: RESOLVED INVALID

(Core :: Security, defect)

Comment 1

[Josh Matthews [:jdm]]

Attachment: patch

Comment 2

[Kai Engert (:KaiE:)]

You should have said what warning you see, so I can know what you're trying to fix.

Comment 3

[Kai Engert (:KaiE:)]

Please be more verbose in general

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 623822 [details] [diff] [review]
patch

r=kaie because the changed variables are supposed to be always positive.

But please provide the warning prior to checking in.

Comment 5

[Daniel Holbert [:dholbert]]

Tagging jdm for needinfo, per comment 4.

(The patch also doesn't apply cleanly anymore, due to a s/PRUnichar/char16_t/ change that affects some contextual code in the middle of the patch.)

Comment 6

[Josh Matthews [:jdm]]

Not sure what the precise warning was anymore, don't see it in the logs.