7551 - mozilla/network/main/mkselect.c includes private NSPR headers.

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Wan-Teh Chang]

The file mozilla/network/main/mkselect.c, revision 1.6, has:
    #if defined(NO_NETWORK_POLLING)
    #include "private/primpl.h"

    #if defined(XP_PC)
    #include "md/_win95.h"

Both private/primpl.h and md/_win95.h are private NSPR
headers and must not be included by a non-NSPR file.

I am going to change NSPR's makefiles so that these
private NSPR headers won't be exported to mozilla/dist.
(See Bugzilla bug #4842.)  Please fix mkselect.c so
that I can check in my changes.  Thanks.

Comment 1

[Wan-Teh Chang]

The inclusion of those two private NSPR headers
was added by [e-mail] in revision 1.6.

Comment 2

[Gagan]

Target to M8.

Comment 3

[James Everingham]

I'm moving this to target M9, Necko will be enabled somewhere during late M8 or
early M9.  We will need to get on this and it cannot be postponed past the M9
milestone.

Comment 4

[leger]

Changing all Networking Library/Browser bugs to Networking-Core component for
Browser.

Occasionally, Bugzilla will burp and cause Verified bugs to reopen when I do
this in a bulk change.  If this happens, I will fix. ;-)

Comment 5

[Gagan]

Necko doesn't use that code. The private NSPR headers are now freeeeee!

Comment 6

[leger]

Bulk move of all Networking-Core (to be deleted component) bugs to new
Networking component.