755153 - add Metadata path to LIBPATH for WinRT on start-msvc11.bat

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[Makoto Kato [:m_kato] (PTO until May 6)]

The latest start-msvc11.bat and start-msvc11-x64.bat don't set LIBPATH correctly for Win8 Metro build.  We should add "<SDK PATH>\8.0\Windows Metadata" to LIBPATH for WinRT into start-msvc11.bat.

Comment 1

[(not currently active) Ted Mielczarek]

We should fix this before spinning a new MozillaBuild release, then.

Comment 2

[Makoto Kato [:m_kato] (PTO until May 6)]

Attachment: fix

Comment 3

[Makoto Kato [:m_kato] (PTO until May 6)]

- guess-msvc.at cannot detect correct path of Windows 8 SDK.  We should use Installed Roots instead of.
- Since VC11 Express isn't released yet. I don't add LIBPATH for express edition.  (After releasing it, we have to investigate express detection and SDK detection for express edition)

Comment 4

[Makoto Kato [:m_kato] (PTO until May 6)]

http://hg.mozilla.org/mozilla-build/rev/0a79accba2b5

We need check the detection for install path after VS11 and Win8 SDK are RTMed.

Comment 5

[Jim Mathies [:jimm]]

The RC changed the location of the metadata to:

C:\Program Files (x86)\Windows Kits\8.0\References\CommonConfiguration\Neutral

As long as we are in here fixing this, I'd like to suggest we add a shell variable to points directly to this folder. I'm currently using this in build config on elm - 

http://mxr.mozilla.org/projects-central/source/elm/widget/windows/winrt/Makefile.in#82

which also broke. Having this set in the shell seems more appropriate.

Since 1.6.1 hasn't gone out yet in bug 754810, reopening this.

Comment 6

[(not currently active) Ted Mielczarek]

The whole point of 1.6.1 is to deliver a release with the VC11 bits for Armen to use, so I'm waiting on you guys to sort it out.

Comment 7

[Jim Mathies [:jimm]]

(In reply to Ted Mielczarek [:ted] from comment #6)
> The whole point of 1.6.1 is to deliver a release with the VC11 bits for
> Armen to use, so I'm waiting on you guys to sort it out.

I think Armen already has all his testing machines set up. cc'ing him.

Comment 8

[Armen [:armenzg]]

(In reply to Jim Mathies [:jimm] from comment #7)
> (In reply to Ted Mielczarek [:ted] from comment #6)
> > The whole point of 1.6.1 is to deliver a release with the VC11 bits for
> > Armen to use, so I'm waiting on you guys to sort it out.
> 
> I think Armen already has all his testing machines set up. cc'ing him.

Sorry Ted! If you have other more important work please go to it. This is not blocking me anymore as I thought initially. Sorry if I caused much trouble.

As I try do add debug builds, packaged tests, symbols and others I might find that I need something from the 1.6.1 release but so far I am not aware of anything blocking me.

Sorry again.

Comment 9

[(not currently active) Ted Mielczarek]

No problem, I haven't actually spent any time on it beyond filing the bug yet. Feel free to comment in that bug if you need it to happen.

Comment 10

[Makoto Kato [:m_kato] (PTO until May 6)]

I filed a bug to microsoft a month ago, then, they said that this was fixed by RC.
https://connect.microsoft.com/VisualStudio/feedback/details/742259/

I should remove setting LIBPATH in start-msvc11*.bat.

Comment 11

[Makoto Kato [:m_kato] (PTO until May 6)]

Attachment: for RC

RC sets LIBPATH for windows.winmd. (See https://connect.microsoft.com/VisualStudio/feedback/details/742259/).  So we should remove this.

But VS11 RC seems to have another problem (https://connect.microsoft.com/VisualStudio/feedback/details/746260/).  So command line environment may always cause ICE.  Should we fix this issue?  (we need rebuild LIBPATH for workaround).

Comment 12

[(not currently active) Ted Mielczarek]

I don't even have a copy of VC11, so instead of me reviewing these changes, feel free to land whatever changes you need in the MozillaBuild repository. When you're satisfied that what we have works, we can release a new MozillaBuild.

Comment 13

[Makoto Kato [:m_kato] (PTO until May 6)]

http://hg.mozilla.org/mozilla-build/rev/c0b8f44cadcd

Comment 14

[Jim Mathies [:jimm]]

This appears to be broken again with the latest mozilla build and the final release of vc2012. I've had to set the following before a build on elm:

set LIBPATH="%LIBPATH%;C:\Program Files (x86)\Windows Kits\8.0\References\CommonConfiguration\Neutral"

Comment 15

[Jim Mathies [:jimm]]

Actually this is interesting, in a fresh vc11 console, I get:

LIBPATH='C:\Windows\Microsoft.NET\Framework\v4.0.30319;C:\Windows\Microsoft.NET\Framework\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\LIB;C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\ATLMFC\LIB;C:\Pr
ogram Files (x86)\Windows Kits\8.0\References\CommonConfiguration\Neutral;\Microsoft.VCLibs\11.0\References\CommonConfiguration\neutral;'

without any changes.

What was needed to build:

LIBPATH='C:\Windows\Microsoft.NET\Framework\v4.0.30319;C:\Windows\Microsoft.NET\Framework\v3.5;C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\LIB;C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\ATLMFC\LIB;C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\vcpackages;C:\Program Files (x86)\Windows Kits\8.0\References\CommonConfiguration\Neutral;'