The default bug view has changed. See this FAQ.

Some jit tests fail with compiler optimizations disabled

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Assigned: Benjamin)

Tracking

Trunk
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Specifically, configure with --disable-optimize and run jit tests to get

FAILURES:
    -m /home/benjamin/dev/repos/y/js/src/jit-test/tests/basic/bug529130.js
    -m -n /home/benjamin/dev/repos/y/js/src/jit-test/tests/basic/bug529130.js
TIMEOUTS:
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
It passes for me on 32-bit Windows and MacOS 10.6. What version of GCC are you using?
(Assignee)

Comment 3

5 years ago
gcc 4.5.3 on Linux.
OS: All → Linux
(Assignee)

Comment 4

5 years ago
The output looks like

|    0.0s1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
1,2,3,4,5,6,7,8,9
/home/benjamin/dev/repos/y/js/src/jit-test/tests/basic/bug529130.js:6: InternalError: too much recursion
Exit code: 3
That's probably because the test recurs a lot, and usable recursion depth depends on the stack space consumed by the compiler.  I consider this test flaky and ignore failures from it, which quite arguably I shouldn't do.  Maybe we should actually fix the test to not recur so close to the overall limit that compiler-dependent stack sizes makes it fail?
(Assignee)

Comment 6

5 years ago
Is this test even very useful? The code for the bug that it fixes is gone with tracing.
(In reply to Benjamin Peterson from comment #6)
> Is this test even very useful? The code for the bug that it fixes is gone
> with tracing.

Kill it with fire!
(Assignee)

Comment 8

5 years ago
Created attachment 624252 [details] [diff] [review]
kills the offending test
(Assignee)

Comment 9

5 years ago
Created attachment 624258 [details] [diff] [review]
kills offending test
Attachment #624252 - Attachment is obsolete: true
Attachment #624258 - Flags: review?(dmandelin)
(Assignee)

Updated

5 years ago
Attachment #624258 - Flags: review?(dmandelin) → review?(jwalden+bmo)
Attachment #624258 - Flags: review?(jwalden+bmo) → review+

Comment 10

5 years ago
Is this the only test which exercises code which is no longer in use?  Should there be some audit activities to find out?
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 11

5 years ago
(In reply to Paul Wright from comment #10)
> Is this the only test which exercises code which is no longer in use? 
> Should there be some audit activities to find out?

I'm not sure what you mean. The code which this test tested is gone.
w00t!  Always did find that test annoying.
Assignee: general → bpeterson
Status: NEW → ASSIGNED
Keywords: checkin-needed
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla15
...ahem:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1406f8b5d54

Comment 14

5 years ago
(In reply to Benjamin Peterson from comment #11)
> (In reply to Paul Wright from comment #10)
> > Is this the only test which exercises code which is no longer in use? 
> > Should there be some audit activities to find out?
> 
> I'm not sure what you mean. The code which this test tested is gone.

Exactly.  This test tested code which is now gone.  Are there any other tests which also test code which no longer exists?  Is there a way to audit the test suites to find out / clean them up?
https://hg.mozilla.org/mozilla-central/rev/e1406f8b5d54

Leaving open as it's not clear whether more work is planned for this bug or not. Please resolve it if there isn't.
Flags: in-testsuite-
(Assignee)

Comment 16

5 years ago
No tests failure anymore, so this bug specifically is done.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.