Closed
Bug 755206
Opened 12 years ago
Closed 12 years ago
Use ANDROID_SERIAL for make install when defined
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.52 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
adb supports an ANDROID_SERIAL env variable to tell it which of multiple devices to use. This is an alternative to using the -s argument. I've been setting this variable globally on my machine for a while, and bug 745738 broke that setup.
|
Assignee | |
Comment 1•12 years ago
|
||
This keeps using MOZ_ANDROID_INSTALL_TARGET if both are defined, but suggests using ANDROID_SERIAL when several devices are connected, but neither is given.
Attachment #623968 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 2•12 years ago
|
||
An unrelated hunk slipped into the previous patch.
Attachment #623974 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #623968 -
Attachment is obsolete: true
Attachment #623968 -
Flags: review?(mark.finkle)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 623974 [details] [diff] [review] Use ANDROID_SERIAL for make install when defined Looks OK and shouldn't break people using MOZ_ANDROID_INSTALL_TARGET
Attachment #623974 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d88acaf73675
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•