If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use ANDROID_SERIAL for make install when defined

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
Firefox 15
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
adb supports an ANDROID_SERIAL env variable to tell it which of multiple devices to use. This is an alternative to using the -s argument. I've been setting this variable globally on my machine for a while, and bug 745738 broke that setup.
(Assignee)

Comment 1

5 years ago
Created attachment 623968 [details] [diff] [review]
Use ANDROID_SERIAL for make install when defined

This keeps using MOZ_ANDROID_INSTALL_TARGET if both are defined, but suggests using ANDROID_SERIAL when several devices are connected, but neither is given.
Attachment #623968 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

5 years ago
Created attachment 623974 [details] [diff] [review]
Use ANDROID_SERIAL for make install when defined

An unrelated hunk slipped into the previous patch.
Attachment #623974 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
Attachment #623968 - Attachment is obsolete: true
Attachment #623968 - Flags: review?(mark.finkle)
Comment on attachment 623974 [details] [diff] [review]
Use ANDROID_SERIAL for make install when defined

Looks OK and shouldn't break people using MOZ_ANDROID_INSTALL_TARGET
Attachment #623974 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d88acaf73675
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.