Closed Bug 755206 Opened 10 years ago Closed 10 years ago

Use ANDROID_SERIAL for make install when defined

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

adb supports an ANDROID_SERIAL env variable to tell it which of multiple devices to use. This is an alternative to using the -s argument. I've been setting this variable globally on my machine for a while, and bug 745738 broke that setup.
This keeps using MOZ_ANDROID_INSTALL_TARGET if both are defined, but suggests using ANDROID_SERIAL when several devices are connected, but neither is given.
Attachment #623968 - Flags: review?(mark.finkle)
An unrelated hunk slipped into the previous patch.
Attachment #623974 - Flags: review?(mark.finkle)
Attachment #623968 - Attachment is obsolete: true
Attachment #623968 - Flags: review?(mark.finkle)
Comment on attachment 623974 [details] [diff] [review]
Use ANDROID_SERIAL for make install when defined

Looks OK and shouldn't break people using MOZ_ANDROID_INSTALL_TARGET
Attachment #623974 - Flags: review?(mark.finkle) → review+
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/mozilla-central/rev/d88acaf73675
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.