Last Comment Bug 755229 - Use YASM for libvpx on mingw builds
: Use YASM for libvpx on mingw builds
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Jacek Caban
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-15 03:40 PDT by Jacek Caban
Modified: 2012-05-16 19:32 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (7.71 KB, patch)
2012-05-15 03:40 PDT, Jacek Caban
khuey: review+
Details | Diff | Splinter Review

Description Jacek Caban 2012-05-15 03:40:31 PDT
Created attachment 623988 [details] [diff] [review]
fix v1.0

Enabling YASM for mingw builds is mostly a matter of not disabling it in configure script and slightly adjusting libvpx's config files.

The patch succeeded on try:
https://tbpl.mozilla.org/?tree=Try&rev=5738e1258a8c
Comment 1 Jacek Caban 2012-05-16 01:51:08 PDT
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf972dca5a8e
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-05-16 19:32:06 PDT
https://hg.mozilla.org/mozilla-central/rev/cf972dca5a8e

Note You need to log in before you can comment on or make changes to this bug.