755239 - strsclnt password options (-w / -W) are broken

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Kai Engert (:KaiE:)]

Today, some of strsclnt test runs on the NSS build slaves on tinderbox fail:

- some are stuck 
  (with a prompt "enter password for fips db",
   if tests were started in a "screen" session)

- some are failing tests
  (with message "Error opening input terminal for read",
   if tests were run in the background without a terminal)

I can reproduce the "stuck" failure on my local Linux computer.


When running the affected tool interactively, I learned that the reason is, that the "-w nss" option given to strsclnt has no effect.

This scenario has probably not been tested before. 
I think the fix for bug 755108 enabled this test.


Looking at source for both tstclnt and strsclnt, I see that tstclnt calls SSL_SetPKCS11PinArg, but strsclnt does not.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Patch v1

Given that we have a bustage on tinderbox, and given this is an obvious fix, with code copied from tstclnt, I'm checking this in now (rather than backing out 755108).

Comment 2

[Kai Engert (:KaiE:)]

Checking in strsclnt.c;
/cvsroot/mozilla/security/nss/cmd/strsclnt/strsclnt.c,v  <--  strsclnt.c
new revision: 1.72; previous revision: 1.71
done

Comment 3

[Wan-Teh Chang]

Comment on attachment 623999 [details] [diff] [review]
Patch v1

r=wtc.