755267 - History Tab is still blank after Sync is performed

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Cristian Nicolae (:xti)]

Firefox 15.0a1 (2012-05-15)
Device: Galaxy Nexus
OS: Android 4.0.2

Steps to reproduce:
1. Open Fennec (clean profile)
2. Perform Sync and wait until it's done
3. Go to Awesomebar > History

Expected result:
After step 3, the History tab is populated with synced data.

Actual result:
History tab is still blank.

Note:
05-15 16:05:05.478: W/HistoryStage(22520): Not enabling history engine since Fennec history is not migrated.
05-15 16:05:05.478: I/ServerSyncStage(22520): Stage history disabled; skipping.
05-15 16:05:05.478: I/SyncAdapter(22520): Stage completed: syncHistory

Comment 1

[Aaron Train [:aaronmt]]

Is this before or after a migration? I can't reproduce this, Nightly (05/15).

Comment 2

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Is this before or after a migration? I can't reproduce this, Nightly (05/15).

Is it on a clean profile on Native. No profile migration occurs here.

Comment 3

[Cristian Nicolae (:xti)]

Attachment: alogcat - Nightly

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I see a lot of this in the log:

D/FormHistoryProvider(24580): Using path: /data/data/org.mozilla.fennec/files/mozilla/n6aeyfeh.default

D/FormHistoryProvider(24580): Successfully created database helper for profile: default

D/FormHistoryProvider(24580): No profile provided, using default

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I am guessing that passwords have an issue as well :

D/GeckoPasswordsProvider(25044): Using path: /data/data/org.mozilla.fennec/files/mozilla/ue73ymj9.default
D/GeckoPasswordsProvider(25044): Successfully created database helper for profile: default
D/GeckoPasswordsProvider(25044): No profile provided, using default

Comment 6

[Gian-Carlo Pascutto [:gcp]]

    protected void setMigratedHistory() {
        setBooleanPrefTrue(PREFS_MIGRATE_BOOKMARKS_DONE);
    }

doh :(

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Regressed in bug 746860.

Comment 8

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Fix copypaste error.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 746860
User impact if declined: Sync will never work for history on migrated profiles.
Risk to taking this patch (and alternatives if risky): Trivial copypaste error.

Comment 9

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9b3e6d2e0ac

Comment 10

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2919c14e90bd

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d9b3e6d2e0ac

Comment 12

[Adrian Tamas (:AdrianT)]

Verified on:
Build: Nightly 15.0a1 2012-05-17/ Aurora 14.0a2 2012-05-17
Device: HTC Desire Z 
OS: Android 2.3.3

History Tab is populated with entries from both before the sync(mobile history) and after the sync.