Last Comment Bug 755316 - nullhttptransaciton based spdystream does not finish
: nullhttptransaciton based spdystream does not finish
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: 15 Branch
: x86_64 Linux
-- minor (vote)
: mozilla15
Assigned To: Patrick McManus [:mcmanus]
: Patrick McManus [:mcmanus]
Depends on:
  Show dependency treegraph
Reported: 2012-05-15 08:21 PDT by Patrick McManus [:mcmanus]
Modified: 2012-06-21 06:41 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch 0 (1.72 KB, patch)
2012-05-15 08:36 PDT, Patrick McManus [:mcmanus]
honzab.moz: review+
Details | Diff | Splinter Review

Description User image Patrick McManus [:mcmanus] 2012-05-15 08:21:04 PDT
spdystream expects its transaction to produce an http request that it gateways into spdy. a nullHttpTransaction does not do that, and the spdystream will pretty much wait for it to do so until it is timed out (even though NullHttpTransaction has retured BASE_STREAM_CLOSED).

Null transactions only exist on nightly. I haven't been able to produce anything bad with this code path, but it explains why some objects in my log take longer than expected to go away. They might even effectively leak.
Comment 1 User image Patrick McManus [:mcmanus] 2012-05-15 08:36:57 PDT
Created attachment 624055 [details] [diff] [review]
patch 0
Comment 2 User image Honza Bambas (:mayhemer) 2012-05-15 13:45:14 PDT
Comment on attachment 624055 [details] [diff] [review]
patch 0

Review of attachment 624055 [details] [diff] [review]:

Comment 3 User image Patrick McManus [:mcmanus] 2012-05-16 06:29:53 PDT
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-05-16 19:46:42 PDT

Note You need to log in before you can comment on or make changes to this bug.