Closed Bug 755316 Opened 9 years ago Closed 9 years ago

nullhttptransaciton based spdystream does not finish

Categories

(Core :: Networking: HTTP, defect)

15 Branch
x86_64
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

(Whiteboard: [sdpy][http-conn])

Attachments

(1 file)

spdystream expects its transaction to produce an http request that it gateways into spdy. a nullHttpTransaction does not do that, and the spdystream will pretty much wait for it to do so until it is timed out (even though NullHttpTransaction has retured BASE_STREAM_CLOSED).

Null transactions only exist on nightly. I haven't been able to produce anything bad with this code path, but it explains why some objects in my log take longer than expected to go away. They might even effectively leak.
Attached patch patch 0Splinter Review
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attachment #624055 - Flags: review?(honzab.moz)
Comment on attachment 624055 [details] [diff] [review]
patch 0

Review of attachment 624055 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzan
Attachment #624055 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/938102758cea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [sdpy] → [sdpy][http-conn]
You need to log in before you can comment on or make changes to this bug.