755336 - convert integer types in nsAppStartup.cpp

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: convert integer types in nsAppStartup.cpp

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=246f17379cb5

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/246f17379cb5

Comment 3

[Landry Breuil (:gaston)]

Broke the build for me on 64 bits archs :  http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/392/steps/build/logs/stdio

/var/buildslave-mozilla/mozilla-central-amd64/build/toolkit/components/startup/nsAppStartup.cpp:857: error: no matching function for call to 'nsIXULRuntime::GetReplacedLockTime(int64_t*)'
../../../dist/include/nsIXULRuntime.h:63: note: candidates are: virtual nsresult nsIXULRuntime::GetReplacedLockTime(PRInt64*) <near match>

All declarations of GetReplacedLockTime() i've found in mxr are declared using PRInt64*.. and a wild guess would be to fix xpcom/system/nsIXULRuntime.idl.

Comment 4

[Landry Breuil (:gaston)]

As it turns out that using int64_t in nsIXULRuntime.idl doesnt work, i'm trying with a static_cast<PRInt64*> in the caller.

Comment 5

[Landry Breuil (:gaston)]

For the record : xpidl.IDLError: error: type 'int64_t' not found, /var/buildslave-mozilla/mozilla-central-amd64/build/xpcom/system/nsIXULRuntime.idl line 124:11

From http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/393/steps/build/logs/stdio

Build #394 does

-  rv = xr->GetReplacedLockTime(&replacedLockTime);
+  rv = xr->GetReplacedLockTime(static_cast<PRInt64*>(&replacedLockTime));

Comment 6

[Landry Breuil (:gaston)]

Doesnt work, so per bug 717733 comment 2 using reinterpret_cast or declaring replacedLockTime as PRInt64 like it was previously should fix it.

Comment 7

[Landry Breuil (:gaston)]

Tried both, both fixes the issue. Which one should i submit ?

Comment 8

[Landry Breuil (:gaston)]

Attachment: cast GetReplacedLockTime arg to PRInt64

Comment 9

[Benjamin Smedberg]

Comment on attachment 625572 [details] [diff] [review]
cast GetReplacedLockTime arg to PRInt64

If PRInt64 and int64_t are not aliases for eachother, then "replacedLockTime" should continue to be PRInt64 until XPIDL is converted.

Comment 10

[Landry Breuil (:gaston)]

Attachment: Use PRInt64 for replacedLockTime, XPIDL expects a PRInt64

Fiar enough, here's the other fix then.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aade4b52f10e

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aade4b52f10e