"hud is null" when using the edit gcli command

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dcamp, Assigned: jwalker)

Tracking

13 Branch
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 628479 [details] [diff] [review]
Upload 1


This is frankly a huge patch for what it effectively a 2/3 line change (See GcliCommands.jsm). In addition to fixing the problem we:
- Fix a related issue in GCLI
  https://github.com/joewalker/gcli/commit/3f33b1bf9440e20b067a99e76823ecd51c3e4f8c
  I'm not sure it's worth a pull request when you can see it here
- Adding tests for the 'edit' command
  (See bug 759853 for a follow-up to complete this work)
- head.js wasn't implementing 'markup' checking. I added that in
  The code was in the GCLI version of this
- Renamed test->tests to fall inline with the GCLI version
- Fixed tests in pref command as a result of 'markup' not being implemented
- Added my leakHunt code. I find it very useful for finding memory leaks and
  I keep adding it and removing it. I'm leaving it in here to see what people
  think of it.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #628479 - Flags: review?(dcamp)
(Reporter)

Updated

5 years ago
Attachment #628479 - Flags: review?(dcamp) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=a24414165cd4
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/3e0e827bd236
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.