Closed
Bug 755581
Opened 12 years ago
Closed 12 years ago
Some extra post-CPG memory reporters for JS
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: [MemShrink:P2])
Attachments
(5 files)
1.16 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
5.56 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
14.11 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
6.17 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
2.92 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
This will cover things like JSCompartment objects, and cross-compartment wrappers.
Assignee | ||
Comment 1•12 years ago
|
||
This reduces some unnecessary tree nesting in about:memory. This: │ │ ├─────193,200 B (00.05%) -- mjit │ │ │ └──193,200 B (00.05%) ── data [12] Becomes this: │ │ ├─────193,200 B (00.05%) -- mjit-data [12] The nested version made sense when mjit-code was stored in the compartment, but it's now in the runtime.
Attachment #624260 -
Flags: review?(luke)
Assignee | ||
Comment 2•12 years ago
|
||
The "runtime/normal" entry in about:memory only measures DtoaState, so let's change it to "runtime/dtoa".
Attachment #624261 -
Flags: review?(luke)
Updated•12 years ago
|
Attachment #624260 -
Flags: review?(luke) → review+
Updated•12 years ago
|
Attachment #624261 -
Flags: review?(luke) → review+
Assignee | ||
Comment 3•12 years ago
|
||
JSRuntime::sizeOfIncludingThis() is getting unwieldy. This patch puts all those parameters into a struct. It also moves the measurement of a couple of JSRuntime-related sizes into JSRuntime::sizeOfIncludingThis().
Attachment #624265 -
Flags: review?(luke)
Assignee | ||
Comment 4•12 years ago
|
||
This patch adds reporters for the mathCache, ScriptFilenameTable, and JSCompartment objects. The latter is the biggest, 200KB+ at start-up on 64-bit.
Attachment #624267 -
Flags: review?(luke)
Assignee | ||
Comment 5•12 years ago
|
||
This is usually tiny (e.g. 1KB per compartment), but it's a good reporter to have because it might blow out on occasion.
Attachment #624269 -
Flags: review?(luke)
Comment 6•12 years ago
|
||
Comment on attachment 624265 [details] [diff] [review] Patch 3: Clean up JSRuntime::sizeOfIncludingThis() Looks better
Attachment #624265 -
Flags: review?(luke) → review+
Updated•12 years ago
|
Attachment #624267 -
Flags: review?(luke) → review+
Updated•12 years ago
|
Attachment #624269 -
Flags: review?(luke) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Five reviews in under an hour... thanks! \o/
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7a4dc88acf https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1d60b3bc57 https://hg.mozilla.org/integration/mozilla-inbound/rev/2eba6266c527 https://hg.mozilla.org/integration/mozilla-inbound/rev/bf84a728f4ed https://hg.mozilla.org/integration/mozilla-inbound/rev/747124aac893
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3d7a4dc88acf https://hg.mozilla.org/mozilla-central/rev/2b1d60b3bc57 https://hg.mozilla.org/mozilla-central/rev/2eba6266c527 https://hg.mozilla.org/mozilla-central/rev/bf84a728f4ed https://hg.mozilla.org/mozilla-central/rev/747124aac893
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment 10•12 years ago
|
||
Comment on attachment 624265 [details] [diff] [review] Patch 3: Clean up JSRuntime::sizeOfIncludingThis() Review of attachment 624265 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/public/MemoryMetrics.h @@ +152,5 @@ > , currCompartmentStats(NULL) > , mallocSizeOf(mallocSizeOf) > {} > > + js::RuntimeSizes runtime; Should be JS::...
Assignee | ||
Comment 11•12 years ago
|
||
> > + js::RuntimeSizes runtime; > > Should be JS::... Nice catch. I was wondering how that even compiled, when Luke told me we have this: namespace js { using namespace JS } I changed it. Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd6365a8255
Comment 12•12 years ago
|
||
Thanks! https://hg.mozilla.org/mozilla-central/rev/dcd6365a8255
You need to log in
before you can comment on or make changes to this bug.
Description
•