755637 - Follow-up for wantComponents options in sandbox

Status: RESOLVED WONTFIX

(Core :: XPConnect, defect)

Description

[Gabor Krizsanits (INACTIVE)]

This is a follow up for Bug 747434. 

> Yeah, I don't think any of that stuff needs it. Can you make another patch
> that sits underneath this one that does ccx->cx for DefineConstructor,
> XPCWNScope::GetNewOrUsed, XPCWNScope::SetGlobal, and XPCWNScope::XPCWNScope?
> I _think_ that should be all of them. I'd also be happy to write the patch,
> but then we'd need to wait for someone to review it. ;-)

+ AttachComponentsObject which also adds XPCWrappedNative::GetNewOrUsed and XPCNativeInterface::GetNewOrUsed to the list (didn't check any deeper) how about doing all these changes/cleanups in a follow up bug instead?

Comment 1

[Gabor Krizsanits (INACTIVE)]

I looked into this and swapped XPCCallContext& with JSContext* in many function signature, but unfortunately XPCWrappedNative::GetNewOrUsed (which is called from AttachComponentsObject for example) uses XPCCallContext for real. It calls FindTearOff which calls InitTearOff which does this security check involving a GetAppropriateSecurityManager call which I cannot get rid off. (http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCWrappedNative.cpp#2152)

So what now? We still use XPCCallContext at a lot of places where we would only need a JSContext* , do you think it worth to change where it's possible to change? I don't have a strong opinion here.

Comment 2

[Bobby Holley (:bholley)]

Shrug, ok. It was worth a shot. Thanks for looking into it. :-)