Closed Bug 75572 Opened 23 years ago Closed 23 years ago

Separator support in outliner

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9.6

People

(Reporter: cathleennscp, Assigned: hyatt)

References

Details

Attachments

(2 files, 1 obsolete file)

need seperator support for outliner, bookmark needs it.
hyatt said he will do it! :-)
Blocks: 73508
--> arik
Assignee: hyatt → arik
Summary: seperator support in outliner → Separator support in outliner
will this make it for 0.9?
could make it. don't know yet, need to talk to hyatt.
Status: NEW → ASSIGNED
this won't make it to 0.9

sorry ;-(
Target Milestone: --- → mozilla0.9.1
pushing off
Target Milestone: mozilla0.9.1 → mozilla1.0
Attached patch proposed fix (obsolete) — Splinter Review
Work on this bug was very similar like work on thread lines.
Separator is represented as double horizontal line.
You can style it with border-top and border-bottom.
I've made changes to content, layout and themes.

Ben, arik can you review this ?

Thanks.
i will review this rsn... thanks ;-)
This is blocking a couple outliner conversions; arik, can you review?
Any chance of getting a review soon? Bookmark conversion to outliner is one of
the bugs that depend on this one.
--> me
Assignee: arik → hyatt
Status: ASSIGNED → NEW
Comments on the patch.  I'd prefer having an IsSeparator method on
nsIOutlinerView.  This is just like IsSelected or IsContainer, a sort of
built-in property that should be checked with its own method.  Just like
IsSelected or IsContainer, make sure the scratch array is pre-filled with the
separator atom if IsSeparator returns true.  Do not make the back end view have
to fill in a separator atom.  Just let them answer true or false from the method
on nsIOutlinerView.

Looking forward to a new patch.

Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.6
Attached patch new patchSplinter Review
Attachment #34207 - Attachment is obsolete: true
I've attached a new patch. It should address hyatt's comments.
I'm not sure if we really need "separator" atom at all,
now we have nsIOutlinerView::IsSeparator() to decide whether to paint cells or
separator.
::moz-outliner-separator pseudoclass is used to obtain separator style.
Looks good.  sr=hyatt
adding waterson to CC list
Sure, looks good to me, r=waterson. File a bug on me to implement IsSeparator()
properly in the nsXULOutlinerBuilder.
Attachment #51502 - Flags: superreview+
Attachment #51502 - Flags: review+
Also, thwack ben in email and let him know this bug has been fixed, since ben
doesn't read bugmail.
all but security/ checked in
complete fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Stupid question on this which I probably don't know enough to ask, but it looks
like the separator is always drawn while a cell is only drawn if it intersects
the dirty rect.  Is this the intention, or did I read this wrong?
Paint() method calls PaintRow() only if rowRect intersects dirty rect.
PaintRow() paints a separator or cells. Cells are painted only if they intersect
dirty rect.
You mean to paint only part of a separator ?
That part which intersect dirty rect ?
Ah, I missed that.  I see now that Paint() only calls PaintRow() if the row
intersects with the dirty rect.  I saw the dirty rect check in PaintRow() for
individual cells, and wondered why there wasn't a check like that for the
separator.  I didn't realize it was done earlier.

As I said, I probably didn't know enough to ask that question!
Separators works nicely in bookmarks (which is outliner based). VERIFIED FIXED
with 2002-03-28-08 on Linux.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: