Closed
Bug 75572
Opened 23 years ago
Closed 23 years ago
Separator support in outliner
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: cathleennscp, Assigned: hyatt)
References
Details
Attachments
(2 files, 1 obsolete file)
17.08 KB,
patch
|
janv
:
review+
janv
:
superreview+
|
Details | Diff | Splinter Review |
1.35 KB,
patch
|
Details | Diff | Splinter Review |
need seperator support for outliner, bookmark needs it. hyatt said he will do it! :-)
Assignee | ||
Comment 1•23 years ago
|
||
--> arik
Assignee: hyatt → arik
Summary: seperator support in outliner → Separator support in outliner
Comment 2•23 years ago
|
||
will this make it for 0.9?
Comment 3•23 years ago
|
||
could make it. don't know yet, need to talk to hyatt.
Status: NEW → ASSIGNED
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
Work on this bug was very similar like work on thread lines. Separator is represented as double horizontal line. You can style it with border-top and border-bottom. I've made changes to content, layout and themes. Ben, arik can you review this ? Thanks.
Comment 8•23 years ago
|
||
i will review this rsn... thanks ;-)
Comment 9•23 years ago
|
||
This is blocking a couple outliner conversions; arik, can you review?
Comment 10•23 years ago
|
||
Any chance of getting a review soon? Bookmark conversion to outliner is one of the bugs that depend on this one.
Assignee | ||
Comment 12•23 years ago
|
||
Comments on the patch. I'd prefer having an IsSeparator method on nsIOutlinerView. This is just like IsSelected or IsContainer, a sort of built-in property that should be checked with its own method. Just like IsSelected or IsContainer, make sure the scratch array is pre-filled with the separator atom if IsSeparator returns true. Do not make the back end view have to fill in a separator atom. Just let them answer true or false from the method on nsIOutlinerView. Looking forward to a new patch.
Status: NEW → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.6
Comment 13•23 years ago
|
||
Updated•23 years ago
|
Attachment #34207 -
Attachment is obsolete: true
Comment 14•23 years ago
|
||
I've attached a new patch. It should address hyatt's comments. I'm not sure if we really need "separator" atom at all, now we have nsIOutlinerView::IsSeparator() to decide whether to paint cells or separator. ::moz-outliner-separator pseudoclass is used to obtain separator style.
Assignee | ||
Comment 15•23 years ago
|
||
Looks good. sr=hyatt
Comment 16•23 years ago
|
||
adding waterson to CC list
Comment 17•23 years ago
|
||
Sure, looks good to me, r=waterson. File a bug on me to implement IsSeparator() properly in the nsXULOutlinerBuilder.
Updated•23 years ago
|
Attachment #51502 -
Flags: superreview+
Attachment #51502 -
Flags: review+
Assignee | ||
Comment 18•23 years ago
|
||
Also, thwack ben in email and let him know this bug has been fixed, since ben doesn't read bugmail.
Comment 19•23 years ago
|
||
Comment 20•23 years ago
|
||
all but security/ checked in
Comment 21•23 years ago
|
||
complete fix checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 22•23 years ago
|
||
Stupid question on this which I probably don't know enough to ask, but it looks like the separator is always drawn while a cell is only drawn if it intersects the dirty rect. Is this the intention, or did I read this wrong?
Comment 23•23 years ago
|
||
Paint() method calls PaintRow() only if rowRect intersects dirty rect. PaintRow() paints a separator or cells. Cells are painted only if they intersect dirty rect. You mean to paint only part of a separator ? That part which intersect dirty rect ?
Comment 24•23 years ago
|
||
Ah, I missed that. I see now that Paint() only calls PaintRow() if the row intersects with the dirty rect. I saw the dirty rect check in PaintRow() for individual cells, and wondered why there wasn't a check like that for the separator. I didn't realize it was done earlier. As I said, I probably didn't know enough to ask that question!
Comment 25•22 years ago
|
||
Separators works nicely in bookmarks (which is outliner based). VERIFIED FIXED with 2002-03-28-08 on Linux.
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•