755816 - Index default bookmarks from 0, not from 1

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

private void createDefaultBookmarks(SQLiteDatabase db, String pattern) {

...
            int pos = 1;
            for (int i = 0; i < fields.length; i++) {

...


Sync then comes along and repositions them all to 0-indexed, like its other folders.

Can we change that to start at 0?

Comment 1

[:Margaret Leibovic]

(In reply to Richard Newman [:rnewman] from comment #0)

> Can we change that to start at 0?

Sounds reasonable to me. Wes, any reason why we didn't do that in the first place?

Comment 2

[Richard Newman [:rnewman]]

Attachment: Trivial patch. v1

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Is pos 0 a special index?

Comment 4

[Richard Newman [:rnewman]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Is pos 0 a special index?

This is just the POSITION column in the DB. It's only used by Sync.

Comment 5

[Wesley Johnston (:wesj)]

We use it for sort order in the bookmarks list:

    static final String DEFAULT_BOOKMARKS_SORT_ORDER = Bookmarks.TYPE
            + " ASC, " + Bookmarks.POSITION + " ASC, " + Bookmarks._ID
            + " ASC";

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 624443 [details] [diff] [review]
Trivial patch. v1

Review of attachment 624443 [details] [diff] [review]:
-----------------------------------------------------------------

I'm guessing this is vestigial or something, but since I can't remember why I did it and the patch works fine locally, I'm good with it.

Comment 7

[Richard Newman [:rnewman]]

Thanks for testing, Wes!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e664ca7c3bab

Comment 9

[Richard Newman [:rnewman]]

I just noticed that there's a follow-up for this for special folders, too:

             createOrUpdateSpecialFolder(db, Bookmarks.TOOLBAR_FOLDER_GUID,
                 R.string.bookmarks_folder_toolbar, 1);
             createOrUpdateSpecialFolder(db, Bookmarks.MENU_FOLDER_GUID,
                 R.string.bookmarks_folder_menu, 2);
             createOrUpdateSpecialFolder(db, Bookmarks.TAGS_FOLDER_GUID,
                 R.string.bookmarks_folder_tags, 3);
             createOrUpdateSpecialFolder(db, Bookmarks.UNFILED_FOLDER_GUID,
                 R.string.bookmarks_folder_unfiled, 4);
+            createOrUpdateSpecialFolder(db, Bookmarks.READING_LIST_FOLDER_GUID,
+                R.string.bookmarks_folder_reading_list, 5);

Comment 10

[Richard Newman [:rnewman]]

(In reply to Richard Newman [:rnewman] from comment #9)
> I just noticed that there's a follow-up for this for special folders, too:

Bah, 'cept I missed the two lines above it. Disregard!