755902 - crash in nsDOMWindowUtils::GetFileId with nsDOMWindowUtils::getFileId(null)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase (uses enhanced privileges)

This bug was filed from the Socorro interface and is 
report bp-1c26e597-d903-4787-b96a-f53aa2120516 .
============================================================= 
0 	xul.dll 	nsDOMWindowUtils::GetFileId 	dom/base/nsDOMWindowUtils.cpp:2275
1 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
2 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2389
3 	xul.dll 	XPC_WN_CallMethod 	js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1541
4 	mozjs.dll 	js::types::TypeSet::addType 	js/src/jsinferinlines.h:1158
5 	mozjs.dll 	js::Interpret 	js/src/jsinterp.cpp:2744
6 	mozjs.dll 	js::types::TypeScript::SetThis 	js/src/jsinferinlines.h:723
7 	mozjs.dll 	js::ExecuteKernel 	js/src/jsinterp.cpp:678
8 	mozjs.dll 	js::Execute 	js/src/jsinterp.cpp:720
9 	mozjs.dll 	EvaluateUCScriptForPrincipalsCommon 	js/src/jsapi.cpp:5321
10 	mozjs.dll 	JS_EvaluateUCScriptForPrincipalsVersionOrigin 	js/src/jsapi.cpp:5358
11 	xul.dll 	nsJSContext::EvaluateString 	dom/base/nsJSEnvironment.cpp:1485
12 	xul.dll 	nsScriptLoader::EvaluateScript 	content/base/src/nsScriptLoader.cpp:910
13 	xul.dll 	nsScriptLoader::ProcessRequest 	content/base/src/nsScriptLoader.cpp:803
14 	xul.dll 	nsScriptLoader::ProcessScriptElement 	content/base/src/nsScriptLoader.cpp:749
15 	xul.dll 	nsScriptElement::MaybeProcessScript 	content/base/src/nsScriptElement.cpp:169

Comment 1

[Scoobidiver (away)]

I don't crash with the testcase.

Comment 2

[Martijn Wargers (dead)]

Because it uses enhanced privileges, it's probably easiest in current builds to test it from chrome:// urls, since they removed the enhanced privs UI.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Jan, could you take a look?

Comment 4

[Jan Varga [:janv]]

ok

Comment 5

[Jan Varga [:janv]]

the patch for 726593 fixes this crash, I changed getFileId() to take a jsval
anyway, I added a new test to check the getFileId(null)

Comment 6

[Jan Varga [:janv]]

fixed along with bug 726593