store JSON in memcache by default, not pickles

VERIFIED FIXED

Status

Cloud Services
Server: Sync
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

(Assignee)

Description

6 years ago
Current syncstorage stores pickled data into memcache by default, but has an option to use JSON instead.  I think we should just remove the use of pickles and make it JSON throughout.
I don't know that this is reasonably possible before 2.0. Doing it would require us to blow away current data, and that causes sufficient trouble that we'd need a compelling reason to go there.
(Assignee)

Comment 2

6 years ago
Indeed, I should have said "for AITC/Sync2.0".

Using pickles is equivalent to loading code out of memcached and executing it.  In theory this is fine since we control memcached, so there shouldn't be anything malicious in there.  But it gives me a bad vibe all the same.
Whiteboard: [qa?]
(Assignee)

Comment 3

6 years ago
This was done as part of the backend refactor in Bug 770162.  It now uses mozsvc.storage.mcclient which serializes all values as JSON, always.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
OK. Marking as Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.