Closed
Bug 755968
Opened 12 years ago
Closed 12 years ago
Clarify text on button that restarts/updates
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: gkw, Assigned: jhk)
Details
(Whiteboard: [good first bug][mentor=gary@rumblingedge.com][lang=js])
Attachments
(1 file, 2 obsolete files)
2.60 KB,
patch
|
bwinton
:
review+
gkw
:
feedback+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #661057 +++ Currently, the button in the About window shows "Apply Update" when an update is ready to install. Let's change this to say "Restart to Update" instead, which synchronizes with Firefox.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #624775 -
Flags: feedback?(gary)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #624775 -
Attachment is obsolete: true
Attachment #624775 -
Flags: feedback?(gary)
Attachment #624776 -
Flags: feedback?(gary)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 624776 [details] [diff] [review] Patch(v1) Thank you for coming up with the patch, good effort! However, this is incorrect. Thunderbird calls /mail/locales/en-US/chrome/messenger/messenger.properties instead of browser.properties. The same goes for /mail/base/content/aboutDialog.js. Please make the change in the /mail/ files instead.
Attachment #624776 -
Flags: feedback?(gary) → feedback-
Comment 4•12 years ago
|
||
Also note you need to change the localization "key" when updating the value, otherwise localizers can't keep up.
Assignee | ||
Comment 5•12 years ago
|
||
ah I thought it was Firefox bug :(. Here is the patch for Thunderbird.
Attachment #624776 -
Attachment is obsolete: true
Attachment #624815 -
Flags: feedback?(gary)
Reporter | ||
Comment 6•12 years ago
|
||
Comment on attachment 624815 [details] [diff] [review] Patch(v2) And as Magnus mentions, you'll have to change the key as well, an example (and reasoning) is in: bug 432903 comment 6
Attachment #624815 -
Flags: feedback?(gary) → feedback-
Reporter | ||
Comment 7•12 years ago
|
||
cc'ing Philipp, will calendar.properties need to be changed as well?
Comment 8•12 years ago
|
||
Well, since Sunbird is no longer maintained its very much optional. r=NPOTB for any changes there given Gary has taken a look.
Reporter | ||
Comment 9•12 years ago
|
||
Comment on attachment 624815 [details] [diff] [review] Patch(v2) Actually on second thoughts, the key already is bumped to update.restart.updateButton.label instead of update.restart.applyButton.label Moreover bumping calender.properties is optional, so sending this for review.
Attachment #624815 -
Flags: review?(bwinton)
Attachment #624815 -
Flags: feedback-
Attachment #624815 -
Flags: feedback+
Comment 10•12 years ago
|
||
Comment on attachment 624815 [details] [diff] [review] Patch(v2) Looks good. r=me! Thanks, Blake.
Attachment #624815 -
Flags: review?(bwinton) → review+
Reporter | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 11•12 years ago
|
||
https://hg.mozilla.org/comm-central/rev/7f2dcebab499
Assignee: nobody → jigneshhk1992
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in
before you can comment on or make changes to this bug.
Description
•