Last Comment Bug 755968 - Clarify text on button that restarts/updates
: Clarify text on button that restarts/updates
Status: RESOLVED FIXED
[good first bug][mentor=gary@rumbling...
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Jignesh Kakadiya [:jhk]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-16 17:25 PDT by Gary Kwong [:gkw] [:nth10sd]
Modified: 2012-05-23 17:34 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch(v1) (3.02 KB, patch)
2012-05-17 09:28 PDT, Jignesh Kakadiya [:jhk]
no flags Details | Diff | Splinter Review
Patch(v1) (3.02 KB, patch)
2012-05-17 09:32 PDT, Jignesh Kakadiya [:jhk]
gary: feedback-
Details | Diff | Splinter Review
Patch(v2) (2.60 KB, patch)
2012-05-17 11:51 PDT, Jignesh Kakadiya [:jhk]
bwinton: review+
gary: feedback+
Details | Diff | Splinter Review

Description Gary Kwong [:gkw] [:nth10sd] 2012-05-16 17:25:01 PDT
+++ This bug was initially created as a clone of Bug #661057 +++

Currently, the button in the About window shows "Apply Update" when an update is ready to install.

Let's change this to say "Restart to Update" instead, which synchronizes with Firefox.
Comment 1 Jignesh Kakadiya [:jhk] 2012-05-17 09:28:01 PDT
Created attachment 624775 [details] [diff] [review]
Patch(v1)
Comment 2 Jignesh Kakadiya [:jhk] 2012-05-17 09:32:09 PDT
Created attachment 624776 [details] [diff] [review]
Patch(v1)
Comment 3 Gary Kwong [:gkw] [:nth10sd] 2012-05-17 10:30:57 PDT
Comment on attachment 624776 [details] [diff] [review]
Patch(v1)

Thank you for coming up with the patch, good effort!

However, this is incorrect. Thunderbird calls /mail/locales/en-US/chrome/messenger/messenger.properties instead of browser.properties.

The same goes for /mail/base/content/aboutDialog.js.

Please make the change in the /mail/ files instead.
Comment 4 Magnus Melin 2012-05-17 11:49:17 PDT
Also note you need to change the localization "key" when updating the value, otherwise localizers can't keep up.
Comment 5 Jignesh Kakadiya [:jhk] 2012-05-17 11:51:39 PDT
Created attachment 624815 [details] [diff] [review]
Patch(v2)

ah I thought it was Firefox bug :(.
Here is the patch for Thunderbird.
Comment 6 Gary Kwong [:gkw] [:nth10sd] 2012-05-17 13:16:33 PDT
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

And as Magnus mentions, you'll have to change the key as well, an example (and reasoning) is in:

bug 432903 comment 6
Comment 7 Gary Kwong [:gkw] [:nth10sd] 2012-05-17 13:17:11 PDT
cc'ing Philipp, will calendar.properties need to be changed as well?
Comment 8 Philipp Kewisch [:Fallen] 2012-05-17 17:52:34 PDT
Well, since Sunbird is no longer maintained its very much optional. r=NPOTB for any changes there given Gary has taken a look.
Comment 9 Gary Kwong [:gkw] [:nth10sd] 2012-05-21 15:43:44 PDT
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

Actually on second thoughts, the key already is bumped to update.restart.updateButton.label instead of update.restart.applyButton.label

Moreover bumping calender.properties is optional, so sending this for review.
Comment 10 Blake Winton (:bwinton) (:☕️) 2012-05-23 12:37:08 PDT
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

Looks good.  r=me!

Thanks,
Blake.
Comment 11 Ryan VanderMeulen [:RyanVM] 2012-05-23 17:34:08 PDT
https://hg.mozilla.org/comm-central/rev/7f2dcebab499

Note You need to log in before you can comment on or make changes to this bug.