Clarify text on button that restarts/updates

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gkw, Assigned: jhk)

Tracking

Trunk
Thunderbird 15.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=gary@rumblingedge.com][lang=js])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #661057 +++

Currently, the button in the About window shows "Apply Update" when an update is ready to install.

Let's change this to say "Restart to Update" instead, which synchronizes with Firefox.
(Assignee)

Comment 1

5 years ago
Created attachment 624775 [details] [diff] [review]
Patch(v1)
Attachment #624775 - Flags: feedback?(gary)
(Assignee)

Comment 2

5 years ago
Created attachment 624776 [details] [diff] [review]
Patch(v1)
Attachment #624775 - Attachment is obsolete: true
Attachment #624775 - Flags: feedback?(gary)
Attachment #624776 - Flags: feedback?(gary)
(Reporter)

Comment 3

5 years ago
Comment on attachment 624776 [details] [diff] [review]
Patch(v1)

Thank you for coming up with the patch, good effort!

However, this is incorrect. Thunderbird calls /mail/locales/en-US/chrome/messenger/messenger.properties instead of browser.properties.

The same goes for /mail/base/content/aboutDialog.js.

Please make the change in the /mail/ files instead.
Attachment #624776 - Flags: feedback?(gary) → feedback-

Comment 4

5 years ago
Also note you need to change the localization "key" when updating the value, otherwise localizers can't keep up.
(Assignee)

Comment 5

5 years ago
Created attachment 624815 [details] [diff] [review]
Patch(v2)

ah I thought it was Firefox bug :(.
Here is the patch for Thunderbird.
Attachment #624776 - Attachment is obsolete: true
Attachment #624815 - Flags: feedback?(gary)
(Reporter)

Comment 6

5 years ago
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

And as Magnus mentions, you'll have to change the key as well, an example (and reasoning) is in:

bug 432903 comment 6
Attachment #624815 - Flags: feedback?(gary) → feedback-
(Reporter)

Comment 7

5 years ago
cc'ing Philipp, will calendar.properties need to be changed as well?
Well, since Sunbird is no longer maintained its very much optional. r=NPOTB for any changes there given Gary has taken a look.
(Reporter)

Comment 9

5 years ago
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

Actually on second thoughts, the key already is bumped to update.restart.updateButton.label instead of update.restart.applyButton.label

Moreover bumping calender.properties is optional, so sending this for review.
Attachment #624815 - Flags: review?(bwinton)
Attachment #624815 - Flags: feedback-
Attachment #624815 - Flags: feedback+
Comment on attachment 624815 [details] [diff] [review]
Patch(v2)

Looks good.  r=me!

Thanks,
Blake.
Attachment #624815 - Flags: review?(bwinton) → review+
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7f2dcebab499
Assignee: nobody → jigneshhk1992
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.