Closed Bug 755999 Opened 8 years ago Closed 8 years ago

Fix various l10n repack paths to work with Thunderbird

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jhopkins, Assigned: jhopkins)

References

Details

Attachments

(2 files)

Various paths need to be fixed up so l10n repacks work with Thunderbird.
Attachment #624640 - Flags: review?(mbanner)
Attached patch tools patchSplinter Review
Some urgency on this patch as it's blocking Thunderbird 13.0b2 repacks.
Attachment #624641 - Flags: review?(rail)
(In reply to John Hopkins (:jhopkins) from comment #2)
> Created attachment 624641 [details] [diff] [review]
> tools patch
> 
> Some urgency on this patch as it's blocking Thunderbird 13.0b2 repacks.

I started Firefox win32 and linux64 builds in staging to make sure the patch doesn't break anything.

BTW, this patch shouldn't block you, since you don't sign Thunderbird binaries as a part of build process. L10N repacks shouldn't create partial MAR files using unsigned binaries, because they are useless and will be overwritten by the updates builder. If for some reason your automation tries to create partial MARs, you should review your configs and disable this step by setting releaseConfig['enablePartialMarsAtBuildTime'] = False.
Comment on attachment 624641 [details] [diff] [review]
tools patch

It failed for Firefox repacks:

command: START
command: perl /builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/dist/../../../tools/update-packaging/unwrap_full_update.pl ../../../../firefox-13.0b3.af.complete.mar
command: cwd: /builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/dist/previous
command: env: {'MAR': '/builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/dist/host/bin/mar', 'MOZ_MAKE_COMPLETE_MAR': '1', 'UPLOAD_USER': 'ffxbld', 'MBSDIFF': '/builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/dist/host/bin/mbsdiff', 'MOZ_OBJDIR': 'obj-l10n', 'LOCALE_MERGEDIR': '/builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/browser/locales/merged', 'UPLOAD_SSH_KEY': '~/.ssh/ffxbld_dsa', 'ZIP_IN': '/builds/slave/rel-m-beta-lnx64-rpk-1/firefox.tar.bz2', 'MOZ_SIGN_CMD': '/tools/python-2.6.5/bin/python /builds/slave/rel-m-beta-lnx64-rpk-1/scripts/release/signing/signtool.py --cachedir /builds/slave/rel-m-beta-lnx64-rpk-1/signing_cache -t /builds/slave/rel-m-beta-lnx64-rpk-1/token -n /builds/slave/rel-m-beta-lnx64-rpk-1/nonce -c /builds/slave/rel-m-beta-lnx64-rpk-1/scripts/release/signing/host.cert -H signing1.build.scl1.mozilla.com:9110 -H signing2.build.scl1.mozilla.com:9110', 'UPLOAD_HOST': 'dev-stage01.srv.releng.scl3.mozilla.com', 'POST_UPLOAD_CMD': 'post_upload.py -p firefox -n 1 -v 13.0b4 --release-to-candidates-dir --signed', 'AB_CD': 'af', 'MOZ_PKG_VERSION': '13.0b4', 'UPLOAD_TO_TEMP': '1', 'MOZ_PKG_PRETTYNAMES': '1'}
command: output:
Can't open perl script "/builds/slave/rel-m-beta-lnx64-rpk-1/mozilla-beta/obj-l10n/dist/../../../tools/update-packaging/unwrap_full_update.pl": No such file or directory
command: END (0.00s elapsed)
Attachment #624641 - Flags: review?(rail) → review-
Let's revisit this when we enable signing in bug 730328.  It shouldn't be hard to fine-tune the patch to get around the issues above.
Blocks: 730328
No longer blocks: 744601
Attachment #624640 - Flags: review?(mbanner)
No longer blocks: 730328
Blocks: 730328
Fixed bug http://hg.mozilla.org/build/tools/rev/e03f1fcb9891 (bug 730328)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.