756003 - iframe and scrollable containers not working in 14.0beta android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[sam boyel]

User Agent: Mozilla/5.0 (Linux; U; Android 2.3.5; en-in; HTC_Explorer_A310e Build/GRJ90) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Mobile Safari/533.1

Steps to reproduce:

Try to scroll through scrollable container contents in web page.


Actual results:

Contents didnt scroll as it is supposed to be scrolling to show all contents.


Expected results:

Scroll to show all the contents in container by flicking the screen with a finger, as working on previous versions.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Do you have a specific URL on which this problem happens? There were some iframe problems (bug 722657, bug 732364) in previous builds but the beta should have those fixed. Having a specific page and steps to reproduce the problem you're seeing would be helpful for us to diagnose the problem.

Comment 2

[Martijn Wargers (dead)]

Sam, can you please give us an url that shows this problem, so we are able to investigate it?

Comment 3

[Martijn Wargers (dead)]

Sam replied to me by mail that he could reproduce this on http://www.jabong.com/men/shoes/mens-casual-shoes/ with the overflow:scroll block on the left.
I can reproduce it, I'm unable to pan that block.
I'll try to come up with a testcase.

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This looks like a different issue from bug 755971, so nom'ing.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Yoinking from Cwiiis since my blockers were minused and this was an easy fix. The element in question has overflow-y: scroll but overflow-x: hidden, so the "overflow" property returns "". Patch checks both x and y proeprties.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Also feel free to approve for aurora/beta and land if needed :)

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d817c805af5

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 630311 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: some divs that should be scrollable won't be
Testing completed (on m-c, etc.): locally so far
Risk to taking this patch (and alternatives if risky): mobile-only, pretty low risk
String or UUID changes made by this patch: none

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Kats - Is bug 755971 related to this at all? Or is it a completely different issue?

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Bug 755971 is completely different; that one appears to be a layout bug that is making us think the element is scrollable when it is not actually.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/314e6d91a410
https://hg.mozilla.org/releases/mozilla-beta/rev/881db16090d6

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/7d817c805af5

Comment 14

[Martijn Wargers (dead)]

Verified fixed on trunk, Aurora and the latest beta.
I also made sure that the case with the url works fine.

Sam, thanks for mentioning this problem. If you encounter more of these bugs, please file them!