Last Comment Bug 756239 - YouSendIt password prompt focuses compose windows by default
: YouSendIt password prompt focuses compose windows by default
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Preferences (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Mike Conley (:mconley) - (needinfo me!)
:
:
Mentors:
Depends on:
Blocks: BigFiles
  Show dependency treegraph
 
Reported: 2012-05-17 13:20 PDT by Mike Conley (:mconley) - (needinfo me!)
Modified: 2012-05-17 14:03 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Patch v1 (943 bytes, patch)
2012-05-17 13:46 PDT, Mike Conley (:mconley) - (needinfo me!)
mozilla: review+
mozilla: approval‑comm‑aurora+
mozilla: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (needinfo me!) 2012-05-17 13:20:41 PDT
STR:

1)  Open a compose window
2)  Open up the preferences dialog, and choose to create a new YouSendIt account

What happens?

When the password prompt for YouSendIt comes up, it attaches itself to the compose window, which brings the compose window into focus.

What's expected?

YouSendIt's password prompt should attach to the front-most window, in this case.
Comment 1 David :Bienvenu 2012-05-17 13:38:26 PDT
(In reply to Mike Conley (:mconley) from comment #0)
> STR:
> 
> 1)  Open a compose window
> 2)  Open up the preferences dialog, and choose to create a new YouSendIt
> account
> 
> What happens?
> 
> When the password prompt for YouSendIt comes up, it attaches itself to the
> compose window, which brings the compose window into focus.
Hmm, how the heck does it do that?

the options window is modal, so we'd need to make sure the password prompt works if it's attached to the options window.
Comment 2 Mike Conley (:mconley) - (needinfo me!) 2012-05-17 13:46:46 PDT
Created attachment 624873 [details] [diff] [review]
Patch v1

Make YouSendIt attach the auth prompt to the most recently used window.
Comment 3 David :Bienvenu 2012-05-17 13:51:14 PDT
Comment on attachment 624873 [details] [diff] [review]
Patch v1

this is likely to be right 99% of the time. I can imagine cases where it's not (start an attach, switch windows really quickly, have the prompt come up for the switched to window) but the code as it was is always wrong for the options ui.
Comment 4 Mike Conley (:mconley) - (needinfo me!) 2012-05-17 13:57:23 PDT
Comment on attachment 624873 [details] [diff] [review]
Patch v1

This is super low-risk. Probably worth landing in TB 13/14.

Note You need to log in before you can comment on or make changes to this bug.