756239 - YouSendIt password prompt focuses compose windows by default

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1)  Open a compose window
2)  Open up the preferences dialog, and choose to create a new YouSendIt account

What happens?

When the password prompt for YouSendIt comes up, it attaches itself to the compose window, which brings the compose window into focus.

What's expected?

YouSendIt's password prompt should attach to the front-most window, in this case.

Comment 1

[David :Bienvenu]

(In reply to Mike Conley (:mconley) from comment #0)
> STR:
> 
> 1)  Open a compose window
> 2)  Open up the preferences dialog, and choose to create a new YouSendIt
> account
> 
> What happens?
> 
> When the password prompt for YouSendIt comes up, it attaches itself to the
> compose window, which brings the compose window into focus.
Hmm, how the heck does it do that?

the options window is modal, so we'd need to make sure the password prompt works if it's attached to the options window.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Make YouSendIt attach the auth prompt to the most recently used window.

Comment 3

[David :Bienvenu]

Comment on attachment 624873 [details] [diff] [review]
Patch v1

this is likely to be right 99% of the time. I can imagine cases where it's not (start an attach, switch windows really quickly, have the prompt come up for the switched to window) but the code as it was is always wrong for the options ui.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 624873 [details] [diff] [review]
Patch v1

This is super low-risk. Probably worth landing in TB 13/14.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/250046d3b130
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/3931a8792db6
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/fb90c6dc325a