756298 - channel-prefs.js cannot be located in the applications 'pref' directory

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

With bug 746156 the channel-prefs.js for freshly downloaded copies of Firefox is now located in 'preferences' folder rather than 'pref'. We should update libs/application.py with this new location.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Look for channel-prefs.js file in multiple locations. v1.0

This now returns either the 'preferences' or 'pref' folder (in that order) depending on where the file is found. If it's not found a suitable exception is thrown.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 624955 [details] [diff] [review]
Look for channel-prefs.js file in multiple locations. v1.0

>+            if os.path.exists(pref_path):
>+                return pref_path
>+        raise Exception("Channel preferences path not found.")

Please make use of the errors.NotFoundException class here.

With that fixed r=me. Once updated please land it right away and if possible trigger a testrun for the latest nightly builds.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Look for channel-prefs.js file in multiple locations. v1.1

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/89a9caf74e0f