756351 - Don't use hgtool for Thunderbird l10n source checkout

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Hopkins (:jhopkins)]

We're hitting a problem with hgtool pulling branch 'default' and not being able to see our release tag.  For now, let's disable the use of hgtool for Thunderbird l10n source checkouts.

Here is a sample of the error we're hitting:

command: START
command: hg pull -b default http://hg.mozilla.org/releases/mozilla-beta
command: cwd: e:\builds\hg-shared\releases\mozilla-beta
command: output:
pulling from http://hg.mozilla.org/releases/mozilla-beta
searching for changes
adding changesets
adding manifests
adding file changes
added 17 changesets with 40 changes to 39 files
(run 'hg update' to get a working copy)
command: END (14.83s elapsed)

Trying to share e:/builds/hg-shared\releases/mozilla-beta to e:\builds\moz2_slave\tb-rel-comm-beta-w32-rpk-1\comm-beta\mozilla
command: START
command: hg share -U e:/builds/hg-shared\\\\releases/mozilla-beta e:\\\\builds\\\\moz2_slave\\\\tb-rel-comm-beta-w32-rpk-1\\\\comm-beta\\\\mozilla
command: cwd: e:\builds\moz2_slave\tb-rel-comm-beta-w32-rpk-1\comm-beta
command: output:
command: END (0.19s elapsed)

command: START
command: hg branch
command: cwd: e:\builds\moz2_slave\tb-rel-comm-beta-w32-rpk-1\comm-beta\mozilla
command: output:
default

command: END (0.16 elapsed)

command: START
command: hg update -C
command: cwd: e:\builds\moz2_slave\tb-rel-comm-beta-w32-rpk-1\comm-beta\mozilla
command: output:
56767 files updated, 0 files merged, 0 files removed, 0 files unresolved
command: END (373.23s elapsed)

command: START
command: hg parent --template {node|short}
command: cwd: e:\builds\moz2_slave\tb-rel-comm-beta-w32-rpk-1\comm-beta\mozilla
command: output:
TinderboxPrint: <a href="http://hg.mozilla.org/releases/mozilla-beta/rev/5f412ea09aba">revision: 5f412ea09aba</a>
5f412ea09aba
command: END (0.69 elapsed)

abort: unknown revision 'THUNDERBIRD_13_0b2_RELEASE'!
Time: real 8.179 secs (user 6.672+0.000 sys 0.297+0.000)
Executing command: ['python', '../scripts/buildfarm/utils/hgtool.py', 'http://hg.mozilla.org/releases/mozilla-beta', 'e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta\\mozilla']
Executing command: ['hg', 'update', '-r', 'THUNDERBIRD_13_0b2_RELEASE', '-R', 'e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta\\mozilla', '--verbose', '--time']
Traceback (most recent call last):
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta/client.py", line 623, in <module>
    do_hg_pull('mozilla', options.mozilla_repo, options.hg, options.mozilla_rev, options.hgtool)
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta/client.py", line 343, in do_hg_pull
    check_call_noisy(cmd, retryMax=0)
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta/client.py", line 138, in check_call_noisy
    execute_check_call(cmd, *args, **kwargs)
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta/client.py", line 134, in execute_check_call
    check_call(cmd, *args, **kwargs)
  File "d:\mozilla-build\python25\Lib\subprocess.py", line 461, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['hg', 'update', '-r', 'THUNDERBIRD_13_0b2_RELEASE', '-R', 'e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/comm-beta\\mozilla', '--verbose', '--time']' returned non-zero exit status -1
command: END (402.16s elapsed)

make: *** [run_client_py] Error 1
Traceback (most recent call last):
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/scripts/scripts/l10n/create-release-repacks.py", line 233, in <module>
    oldBuildNumber=releaseConfig["oldBuildNumber"],
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/scripts/scripts/l10n/create-release-repacks.py", line 69, in createRepacks
    localeSrcDir, env)
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/scripts/scripts/l10n\../../lib/python\build\l10n.py", line 50, in l10nRepackPrep
    env=env)
  File "e:/builds/moz2_slave/tb-rel-comm-beta-w32-rpk-1/scripts/scripts/l10n\../../lib/python\util\commands.py", line 42, in run_cmd
    return subprocess.check_call(cmd, **kwargs)
  File "d:\mozilla-build\python25\Lib\subprocess.py", line 461, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-f', 'client.mk', 'configure']' returned non-zero exit status 2
program finished with exit code 1
elapsedTime=538.188000

Comment 1

[John Hopkins (:jhopkins)]

Attachment: buildbot-configs patch

Comment 2

[John Hopkins (:jhopkins)]

Comment on attachment 624998 [details] [diff] [review]
buildbot-configs patch

Double-landed in:
 https://hg.mozilla.org/build/buildbot-configs/rev/7ae9a1232feb
 https://hg.mozilla.org/build/buildbot-configs/rev/5cffeacbe540

Comment 3

[[e-mail] (:bhearsum)]

We need to figure out what the issue here is and re-enable hgtool at some point. It has access to the local repository cache, and also does all sorts of retrying. It's very important, especially for releases.

(I understand that you needed to do this temporarily to get unblocked, however.)

Comment 4

[Mark Banner (:standard8)]

As this is a work around for release that means the releases now work, I'm going to close this bug. The follow-up is bug 757798 which blocks the Thunderbird post-integration work bug.