756384 - Maemo/Meego builds should have the "Mobile" token in the UA string

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Henri Sivonen (:hsivonen)]

By code inspection, it seems that only Android builds add the Mobile or Tablet token to the UA string:
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#715

Not having Maemo/Meego report the Mobile token in the UA string breaks the promise of having Firefox for mobile report the Mobile token regardless of OS.

Please add the Mobile token to the UA string on Maemo/Meego phones.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Update to latest N9 device, and add tablet/mobile identification

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 625120 [details] [diff] [review]
Update to latest N9 device, and add tablet/mobile identification

Looks OK, but do you really want the N8x0 to be treated as a tablet? If you're OK with it, that's all that matters to me. I just wanted ot make sure it wasn't a typo.

This patch is Maemo only and won't affect Android or Desktop.

Comment 3

[Oleg Romashin (:romaxa)]

Originally N8x0 has been called as "tablet", actually internet tablet. not exactly sure what is definition of table in Mobile FF language.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Oleg Romashin (:romaxa) from comment #3)
> Originally N8x0 has been called as "tablet", actually internet tablet. not
> exactly sure what is definition of table in Mobile FF language.

What they were called back in the day doesn't really matter for site compatibility. N8x0 are phone-sized devices, so I think "Mobile" would help them get content that better suits their screen size. "Mobile" means the device has the phone form-factor and "Tablet" means device has the iPad form-factor.

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Mobile UA string to Meego builds

Added header, set N8x0 as mobile too

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6aafb053db4e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6aafb053db4e