The default bug view has changed. See this FAQ.

Missing return statement in DrawTargetD2D::FillGlyphsManual

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla15
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 625074 [details] [diff] [review]
fix v1.0

Found on mingw build thanks to -Werror=return-type. While I was on this I've fixed one more warning about unused variable.

BTW, GCC has many more warnings that seem harmless, like an enum not handled in switch statement. I'm happy to fix them, but I'm not sure it's welcomed. Bas, what do you think?
Attachment #625074 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #625074 - Flags: review? → review?(bas.schouten)
(In reply to Jacek Caban from comment #0)
> Created attachment 625074 [details] [diff] [review]
> fix v1.0
> 
> Found on mingw build thanks to -Werror=return-type. While I was on this I've
> fixed one more warning about unused variable.

Ugh, this is just me being blind, our MSVC build warns for this by default as well.

> BTW, GCC has many more warnings that seem harmless, like an enum not handled
> in switch statement. I'm happy to fix them, but I'm not sure it's welcomed.
> Bas, what do you think?

I'm a little indifferent to the specific warning you mentioned, but some may be useful?
Attachment #625074 - Flags: review?(bas.schouten) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Bas Schouten (:bas) from comment #1)
> I'm a little indifferent to the specific warning you mentioned, but some may
> be useful?

I just filled bug 756996 so you can decide seeing the code. Unused variables seem valuable, others are nice to have fixed clean ups so that useful warnings are not shadowed by them.
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dac49054fb1d
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/dac49054fb1d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [autoland-try: -b do -p win32,win64 -u all -t none]
You need to log in before you can comment on or make changes to this bug.