75650 - Posting news msgs doesn't clean up temp files at all

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Cavin Song]

Either you post a new msg or reply to a news msg, temp files don't seems to get 
cleaned up at all.

Comment 1

[Cavin Song]

In nsMsgComposeAndSend::DeliverFileAsNews() the code, for some reason, 
increments the refcnt by two for NNTP service. The comment seems to indicate 
that the code may have problems too!!  Her is the code segment:

if (NS_SUCCEEDED(rv) && nntpService)
{
  .  .  .
  NS_ADDREF_THIS();  // two addrefs on ourselves? This looks bogus too....  
  AddRef();
  .  .  .
}

Any idea why it's done this way?  It may be the reason why the temp files are 
not being cleaned up (in the destructor).

Comment 2

[(not reading, please use [e-mail] instead)]

nice catch cavin.

use 
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mailnews/compose/src/nsMsgSend
.cpp to see when (and why) that was done.

mscott added that comment about the two addref's being bogus.

Comment 3

[Cavin Song]

It was on Nov 22 1999 (v1.140) but did not mention why.
                         

Comment 4

[(not reading, please use [e-mail] instead)]

isn't 1.40 version where mscott added his comment about the addref being bogus?

who made the change before that?  (probably rich, but why?)

Comment 5

[(not reading, please use [e-mail] instead)]

I'm testing a patch from ducarroz that might fix this.

we hope to land tonight, and then you can return to this.

Comment 6

[(not reading, please use [e-mail] instead)]

ducarroz has landed his massive patch.

once you update and rebuild you can continue to investigate.

Comment 7

[Jean-Francois Ducarroz]

Attachment: Fix leak which is the cause of the problem.

Comment 8

[Jean-Francois Ducarroz]

Looks like my patch fix the problem with remote attachment but not with local 
attachment :-(

Comment 9

[Jean-Francois Ducarroz]

...but both cases works fine on Mac for me!

Comment 10

[Jean-Francois Ducarroz]

We are leaking nsMsgAttachmentHandler which hold a reference on
nsMsgComposeAndSend. Therefore the destructor of nsMsgComposeAndSend is never
called which result to those temp files not removed.

Comment 11

[Jean-Francois Ducarroz]

In fact, any local attachment are leaking on Windows and Linux. It's not the
case on Mac because we are doing extra processing for AppleDouble which which
correctly cleanup the attachment. New patch coming...

Comment 12

[Jean-Francois Ducarroz]

accepting :-)

Comment 13

[Jean-Francois Ducarroz]

Attachment: new patch which fix all cases

Comment 14

[Jean-Francois Ducarroz]

R=varada

Comment 15

[(not reading, please use [e-mail] instead)]

looks ok to me.  sr=sspitzer

make sure to test this on multiple platforms, and under all the usual scenarios
(news, mail, news & mail at the same time, bcc, fcc, etc).

Comment 16

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

In verifying this, where would the temp files have been before?  Would they have
been in 
C:\Documents and Settings\Administrator\Application Data\Mozilla\Users50\Default
User\fhihyzp8.slt\News

-or-

C:\Documents and Settings\Administrator\Application Data\Mozilla\Users50\Default
User\fhihyzp8.slt\NewCache

?

Comment 18

[Jean-Francois Ducarroz]

on windows, they are in c:\temp

Comment 19

[(not reading, please use [e-mail] instead)]

on linux, TMPDIR which is probably /tmp.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

Posting to netscape.test on news.mozilla.org showed no signs of temp files
(after completing a post) with builds:

2001-04-18-04 on Win2K (searched C:\TEMP and the Application Data folder and
C:\WINNT\Temp.
2001-04-18-08 RedHat 7.0 using Applications/Text Editor (KDE pre-defined shortcuts).
Not sure where Mac OS 9.1 stores temp files.
And mac doesn't do file extensions like win/linux do, so I'll wait before I
verify on that platform.

Comment 21

[Jean-Francois Ducarroz]

Attachment: Sherlock Search criteria to find temp files

Comment 22

[Jean-Francois Ducarroz]

On Mac, temp files are in an invisible folder on your primary HD named "Temporary Items". This folder is 
automatically cleanup by the OS every time you boot. I have attached a Sherlock Search Criteria that will help you 
find new temp file created by Mozilla Mail during a Send process. Just install this file on your Mac and doubleclick 
on it...

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

I searched for invisible folder "Temporary Items" using Sherlock 2 on Mac OS 9.1
after posting to netscape.test using build 2001-04-19-08 and found only a few
HTML files, nothing related to news at all.