75654 - Bogus cookie description when multiple cookies selected

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P2)

Description

[Stephen P. Morse]

Collect several cookies by browsing
Go to cookie-manager dialog (tasks->privacy->cookie-manager->view-cookies)
Select a cookie in list -- it's properties get displayed
Press shift or control and select another cookie.
  - this causes multiple selections as it is supposed to
  - display of properties is cleared out (as it is supposed to be) except that
    the "secure" field and the "expires" field have values (not supposed to)

This bug is actually an offshoot of bug 27417 which has to do with selecting 
multiple cookies for removal purposes.  I stumbled across this while trying to 
come up with a fix for that one.

Comment 1

[Stephen P. Morse]

As a side effect, I noticed that the "host" or "domain" label in the properties 
section starts off with a lower-case letter whereas all other labels start off 
with upper case.  Related to this bug only tagentially but it's easier to fix 
this all together than to open a separate bug report just for the casing 
problem.

Comment 2

[Stephen P. Morse]

Attachment: patch to fix both problems.

Comment 3

[Eric Vaughan]

-r evaughan

Comment 4

[Stephen P. Morse]

cc'ing alecf for sr

Comment 5

[Alec Flett]

multiple nested ?: are simply hard to read and lead to confusion when you're
maintaining the code. use at least one if/else (or get rid of all the ?: entirely)

Comment 6

[Stephen P. Morse]

Attachment: Removing nested "?" per alecf's comment

Comment 7

[Alec Flett]

awesome... so much easier to understand :)
sr=alecf

Comment 8

[Viswanath Ramachandran]

great work guys, check it in!

Comment 9

[Stephen P. Morse]

Fix was checked in yesterday.  I forgot to mark it closed.

Comment 10

[Stephen P. Morse]

And I still forgot to mark it close.  Let's try again.

Comment 11

[Tom Everingham]

verified 6/27 branch and trunk, winNT 4, Linux rh6, mac os9