nsXBLBinding::GetInsertionPointsFor is now infallible

RESOLVED FIXED in mozilla16

Status

()

Core
XBL
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bsmedberg, Assigned: jhk)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=bsmedberg][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
nsXBLBinding::GetInsertionPointsFor is now infallible (because hashtables are infallible) and we should make it return "void".

Comment 1

5 years ago
http://mxr.mozilla.org/mozilla-central/source/content/xul/templates/src/nsXMLBinding.cpp

Comment 2

5 years ago
Hi, I need some more tips to help.
(Reporter)

Comment 3

5 years ago
The return value of the function (http://hg.mozilla.org/mozilla-central/annotate/c20d415ef1b5/content/xbl/src/nsXBLBinding.cpp#l1401) should be 'void' instead of nsresult, and the callers need to be updated to not error-check it.
(Assignee)

Comment 4

5 years ago
Created attachment 626416 [details] [diff] [review]
Patch(v1)
Attachment #626416 - Flags: review?(benjamin)
(Reporter)

Comment 5

5 years ago
Comment on attachment 626416 [details] [diff] [review]
Patch(v1)

Heh, nobody used the return value anyway? awesome ;-)
Attachment #626416 - Flags: review?(benjamin) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3f52520b774
Flags: in-testsuite-
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/c3f52520b774
Assignee: nobody → jigneshhk1992
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.