Last Comment Bug 756579 - nsXBLBinding::GetInsertionPointsFor is now infallible
: nsXBLBinding::GetInsertionPointsFor is now infallible
Product: Core
Classification: Components
Component: XBL (show other bugs)
: unspecified
: All All
-- trivial (vote)
: mozilla16
Assigned To: Jignesh Kakadiya [:jhk]
: Andrew Overholt [:overholt]
Depends on: 734847
  Show dependency treegraph
Reported: 2012-05-18 13:10 PDT by Benjamin Smedberg [:bsmedberg]
Modified: 2012-06-09 19:48 PDT (History)
7 users (show)
dzbarsky: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch(v1) (2.42 KB, patch)
2012-05-23 06:34 PDT, Jignesh Kakadiya [:jhk]
benjamin: review+
Details | Diff | Splinter Review

Description User image Benjamin Smedberg [:bsmedberg] 2012-05-18 13:10:30 PDT
nsXBLBinding::GetInsertionPointsFor is now infallible (because hashtables are infallible) and we should make it return "void".
Comment 2 User image Xi Yang 2012-05-22 10:56:54 PDT
Hi, I need some more tips to help.
Comment 3 User image Benjamin Smedberg [:bsmedberg] 2012-05-22 13:09:44 PDT
The return value of the function ( should be 'void' instead of nsresult, and the callers need to be updated to not error-check it.
Comment 4 User image Jignesh Kakadiya [:jhk] 2012-05-23 06:34:31 PDT
Created attachment 626416 [details] [diff] [review]
Comment 5 User image Benjamin Smedberg [:bsmedberg] 2012-05-24 06:01:14 PDT
Comment on attachment 626416 [details] [diff] [review]

Heh, nobody used the return value anyway? awesome ;-)
Comment 6 User image David Zbarsky (:dzbarsky) 2012-06-09 15:21:59 PDT
Comment 7 User image Ryan VanderMeulen [:RyanVM] 2012-06-09 19:48:47 PDT

Note You need to log in before you can comment on or make changes to this bug.