Closed Bug 756579 Opened 8 years ago Closed 8 years ago

nsXBLBinding::GetInsertionPointsFor is now infallible

Categories

(Core :: XBL, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: benjamin, Assigned: jhk)

References

Details

(Whiteboard: [mentor=bsmedberg][lang=c++])

Attachments

(1 file)

nsXBLBinding::GetInsertionPointsFor is now infallible (because hashtables are infallible) and we should make it return "void".
Hi, I need some more tips to help.
The return value of the function (http://hg.mozilla.org/mozilla-central/annotate/c20d415ef1b5/content/xbl/src/nsXBLBinding.cpp#l1401) should be 'void' instead of nsresult, and the callers need to be updated to not error-check it.
Attached patch Patch(v1)Splinter Review
Attachment #626416 - Flags: review?(benjamin)
Comment on attachment 626416 [details] [diff] [review]
Patch(v1)

Heh, nobody used the return value anyway? awesome ;-)
Attachment #626416 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Flags: in-testsuite-
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/c3f52520b774
Assignee: nobody → jigneshhk1992
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.