Thunderbird updates builder needs to build patcher tools from mozilla repo, not comm repo

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: coop, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [thunderbird][integration][updates])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
The patcher tools are build from source as part of the build process. These tools live in the mozilla repos (e.g. mozilla-beta). The update step failed for Thunderbird 13.0b2 (first integration release on Firefox infra) because by default the ReleaseUpdatesFactory uses the same source repo as the builds. Because Thunderbird builds require two repos, and the main repo is, e.g., comm-beta which does not contain the patcher tools, the step fails.

ReleaseUpdatesFactory already has an option for this, mozRepoPath, we just need to set it for Thunderbird builds.
(Reporter)

Comment 1

7 years ago
Created attachment 625283 [details] [diff] [review]
Set mozRepoPath when generating Thunderbird release updates

This is the same patch that I pastebin-ed earlier. The patch is actually applied on buildbot-master34 right, and has allowed the updates step to complete.
Attachment #625283 - Flags: review?(jhopkins)
Comment on attachment 625283 [details] [diff] [review]
Set mozRepoPath when generating Thunderbird release updates

Maybe something like this to reduce dependencies on productName?

try:
    moz_repo_path = releaseConfig['sourceRepositories']['mozilla']['path']
except KeyError:
    moz_repo_path = sourceRepoInfo['path']
Assignee: coop → rail
Created attachment 626048 [details] [diff] [review]
Set mozRepoPath

Passes staging:

perl patcher2.pl --build-tools-hg --tools-revision=UPDATE_PACKAGING_R15 --app=thunderbird --brand=Thunderbird --config=patcher-configs/mozBeta-thunderbird-branch-patcher2.cfg
...
Cloning http://hg.mozilla.org/users/raliiev_mozilla.com/mozilla-beta and updating to UPDATE_PACKAGING_R15
Running shell command:
  arg0: hg
  arg1: clone
  arg2: http://hg.mozilla.org/users/raliiev_mozilla.com/mozilla-beta
  arg3: mozilla
...
Attachment #625283 - Attachment is obsolete: true
Attachment #625283 - Flags: review?(jhopkins)
Attachment #626048 - Flags: review?(mbanner)
Comment on attachment 626048 [details] [diff] [review]
Set mozRepoPath

Looks good to me.
Attachment #626048 - Flags: review?(mbanner) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.