Closed Bug 756689 Opened 12 years ago Closed 12 years ago

Re-enable addon-options-displayed notification in Fennec

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox14 fixed, blocking-fennec1.0 soft)

Status:
RESOLVED FIXED
Milestone:
Firefox 15
Tracking Flags:
Tracking Status
firefox14 --- fixed
blocking-fennec1.0 --- soft

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file, 3 obsolete files)

Patch
1.44 KB, patch
mfinkle
: review+
johnath
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This is fired when options for an addon are shown. The code is commented out. We should re-enable it for addon authors.
Attached patch Patch (obsolete) — — Splinter Review 
Un-comments these lines.
Assignee: nobody → wjohnston
Attachment #625301 - Flags: review?(mark.finkle)
Attached patch Patch 2/2 - Deleted table (obsolete) — — Splinter Review 
Whoops. Need to test this a bit more first, but this is better...
Attachment #625301 - Attachment is obsolete: true
Attachment #625301 - Flags: review?(mark.finkle)
Attached patch Patch 3 (obsolete) — — Splinter Review 
Tested with one of my addons.
Attachment #625305 - Attachment is obsolete: true
Attachment #625324 - Flags: review?(mark.finkle)
Crap. Please ignore the dump(JSON.stringify(list)); piece. Stupid hg.
Attached patch Patch — — Splinter Review 
Trying to rush at the end of the day is not working for me. This is the patch I meant!
Attachment #625324 - Attachment is obsolete: true
Attachment #625324 - Flags: review?(mark.finkle)
Attachment #625325 - Flags: review?(mark.finkle)
Attachment #625325 - Flags: review?(mark.finkle) → review+
Might be worth a soft blocker, since this could affect add-on devs.
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → soft
https://hg.mozilla.org/mozilla-central/rev/cd8973ac8ba6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
Comment on attachment 625325 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Original Addons patch for mobile
User impact if declined: More difficult for addon authors to use our already limited UI options
Testing completed (on m-c, etc.): Landed on 5/21
Risk to taking this patch (and alternatives if risky): Very low risk. Mobile only. Addons Manager only. Only runs when opening up options pane.
String or UUID changes made by this patch: None
Attachment #625325 - Flags: approval-mozilla-aurora?
Attachment #625325 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is this ready to push to Aurora?
status-firefox14: --- → affected
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: