756690 - [AccessFu] Add option to not land on images with no alt text

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[Marco Zehe (:MarcoZ)]

This should be on by default. <img src="bla.png" alt="" /> is a solicited way to declare an image as decorative, and we support that. AccessFu should ignore such images when navigating by default. I was just pinged about this by a user, so sending a ping about this.

Comment 2

[Max Li [:maxli]]

Attachment: Patch

Comment 3

[Marco Zehe (:MarcoZ)]

Comment on attachment 763174 [details] [diff] [review]
Patch

First, I noticed that there is code duplication here.
Second: I think nsIAccessible already provides a means for distinguishing whether the name is provided by alt="" or a missing alt attribute. Can't we just use that? See: http://mxr.mozilla.org/mozilla-central/source/accessible/src/generic/ImageAccessible.cpp#84
If we can detect that in here, we should not re-do the computation.

Comment 4

[Max Li [:maxli]]

Attachment: Revised Patch

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 763527 [details] [diff] [review]
Revised Patch

Review of attachment 763527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Just need to change pref type.

::: b2g/app/b2g.js
@@ +635,5 @@
>  
>  // Screen reader support
>  pref("accessibility.accessfu.activate", 2);
> +// Whether to skip images with empty alt text (0 - no, 1 - yes)
> +pref("accessibility.accessfu.skip_empty_images", 1);

If we don't see any other option in the future, this should just be boolean.

Comment 6

[Max Li [:maxli]]

Attachment: Patch with nit fixed

Carrying forward r+.

Comment 7

[Marco Zehe (:MarcoZ)]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f434c4d17c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0f434c4d17c