Closed Bug 756690 Opened 7 years ago Closed 6 years ago

[AccessFu] Add option to not land on images with no alt text

Categories

(Core :: Disability Access APIs, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: eeejay, Assigned: maxli)

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
This should be on by default. <img src="bla.png" alt="" /> is a solicited way to declare an image as decorative, and we support that. AccessFu should ignore such images when navigating by default. I was just pinged about this by a user, so sending a ping about this.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → maxli
Attachment #763174 - Flags: review?(eitan)
Comment on attachment 763174 [details] [diff] [review]
Patch

First, I noticed that there is code duplication here.
Second: I think nsIAccessible already provides a means for distinguishing whether the name is provided by alt="" or a missing alt attribute. Can't we just use that? See: http://mxr.mozilla.org/mozilla-central/source/accessible/src/generic/ImageAccessible.cpp#84
If we can detect that in here, we should not re-do the computation.
Attached patch Revised Patch (obsolete) — Splinter Review
Attachment #763174 - Attachment is obsolete: true
Attachment #763174 - Flags: review?(eitan)
Attachment #763527 - Flags: review?(eitan)
Comment on attachment 763527 [details] [diff] [review]
Revised Patch

Review of attachment 763527 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Just need to change pref type.

::: b2g/app/b2g.js
@@ +635,5 @@
>  
>  // Screen reader support
>  pref("accessibility.accessfu.activate", 2);
> +// Whether to skip images with empty alt text (0 - no, 1 - yes)
> +pref("accessibility.accessfu.skip_empty_images", 1);

If we don't see any other option in the future, this should just be boolean.
Attachment #763527 - Flags: review?(eitan) → review+
Carrying forward r+.
Attachment #763527 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a0f434c4d17c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.