xptcall fails to build with mipsel-linux-android target

RESOLVED FIXED in mozilla15

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

Trunk
mozilla15
Other
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

7 years ago
/home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:45:24: error: sys/regdef.h: No such file or directory
/home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:46:21: error: sys/asm.h: No such file or directory
Assignee

Comment 1

7 years ago
There are several issues:
- ASFLAGS don't include CPPFLAGS, which is required to have the proper include path for the android system headers.
- regdef.h and asm.h are not under sys/ in the android system header for mips.
- ASFLAGS don't include -DANDROID which would allow a special case for android.
- There are different asm.h and regdef.h under asm/ and machine/ none of which allow the xptcall assembly to build.
Assignee

Updated

7 years ago
Assignee: nobody → mh+mozilla
No longer blocks: android-mips
Assignee

Comment 2

7 years ago
Note that setting CPPFLAGS directly during configure fails because "$(DEPTH)/mozilla-config.h" is not valid (mozilla-config.h is not yet created, and $(DEPTH) is a make variable, not a shell variable). Thus the use of COMPILE_CPPFLAGS.
Attachment #625414 - Flags: review?(ted.mielczarek)
Assignee

Comment 3

7 years ago
Err, the patch was not meant to contain the *.s files.
Attachment #625415 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Attachment #625414 - Attachment is obsolete: true
Attachment #625414 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Blocks: android-mips
Assignee

Comment 5

7 years ago
Comment on attachment 625415 [details] [diff] [review]
Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS

Unfortunately, this breaks windows :(
Attachment #625415 - Flags: review?(ted.mielczarek)
Assignee

Comment 6

7 years ago
(In reply to Mike Hommey [:glandium] from comment #5)
> Comment on attachment 625415 [details] [diff] [review]
> Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS
> 
> Unfortunately, this breaks windows :(

Actually, it only breaks win64, which is kind of surprising.
Assignee

Comment 7

7 years ago
Simpler approach, which won't break anything non-Android.
Attachment #625569 - Flags: review?(ted.mielczarek)
Assignee

Updated

7 years ago
Attachment #625415 - Attachment is obsolete: true

Updated

7 years ago
Attachment #625416 - Flags: review?(benjamin) → review+
Attachment #625569 - Flags: review?(ted.mielczarek) → review+
You need to log in before you can comment on or make changes to this bug.