/home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:45:24: error: sys/regdef.h: No such file or directory /home/mh/mozilla-central/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_asm_mips.s:46:21: error: sys/asm.h: No such file or directory
There are several issues: - ASFLAGS don't include CPPFLAGS, which is required to have the proper include path for the android system headers. - regdef.h and asm.h are not under sys/ in the android system header for mips. - ASFLAGS don't include -DANDROID which would allow a special case for android. - There are different asm.h and regdef.h under asm/ and machine/ none of which allow the xptcall assembly to build.
Assignee: nobody → mh+mozilla
No longer blocks: android-mips
Note that setting CPPFLAGS directly during configure fails because "$(DEPTH)/mozilla-config.h" is not valid (mozilla-config.h is not yet created, and $(DEPTH) is a make variable, not a shell variable). Thus the use of COMPILE_CPPFLAGS.
Err, the patch was not meant to contain the *.s files.
Comment on attachment 625415 [details] [diff] [review] Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS Unfortunately, this breaks windows :(
(In reply to Mike Hommey [:glandium] from comment #5) > Comment on attachment 625415 [details] [diff] [review] > Use CPPFLAGS for defines and forced includes, and add them to ASFLAGS > > Unfortunately, this breaks windows :( Actually, it only breaks win64, which is kind of surprising.
Simpler approach, which won't break anything non-Android.
Attachment #625569 - Flags: review?(ted.mielczarek)
Attachment #625415 - Attachment is obsolete: true
Attachment #625569 - Flags: review?(ted.mielczarek) → review+
Target Milestone: --- → mozilla15
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.