Closed Bug 756784 Opened 9 years ago Closed 9 years ago

Make file menu popup more consistent and easier to overlay

Categories

(Toolkit :: View Source, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(1 file)

At the moment viewSource and viewPartialSource use filemenu-popup whereas the majority of the code base uses menu_FilePopup
Changing viewSource and viewPartialSource to menu_FilePopup will make things more consistent and the files easier to overlay.
Attachment #625410 - Flags: review?(gavin.sharp)
Blocks: 756787
What was the motivation for filing this? Are there specific overlays that this will help?
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> What was the motivation for filing this? Are there specific overlays that
> this will help?
This would enable SeaMonkey to add menu items to the file menu through utilityOverlay.xul which are common to all windows within the suite, rather than having to add them to both viewSourceOverlay.xul and utilityOverlay.xul which is done at the moment.
Attachment #625410 - Flags: review?(gavin.sharp) → review+
Comment on attachment 625410 [details] [diff] [review]
Change id of file menu popup [Checked in: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/b1a0fb2bdbf7
Attachment #625410 - Attachment description: Change id of file menu popup → Change id of file menu popup [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.