756790 - Duplicate dependencies on some bugs

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Mike Hommey [:glandium]]

It started with bug 734309. I don't know when exactly, but after I added an alias to the bug, I noticed it had duplicate dependencies. That is, instead of "729019 731119 750620 756740", it was "729019 729019 731119 731119 750620 750620 756740 756740".
I thus de-duplicated. When saving the changes, all dependencies were removed. Adding them again did show them only once.
But afterwards, going to each dependencies, they all had duplicated dependencies. And for each of them, de-duplicating first removed the deps, which I added again.
I left the last one with the duplicated deps as evidence. See bug 756740.

Comment 2

[Mike Hommey [:glandium]]

Bug 756439 does this too.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This bug is causing dependencies to be cleared all over the place.

Comment 4

[David Lawrence [:dkl]]

I am unable to recreate this problem on my test instance and I do not see any recent changes in the bmo/4.0 repo that would have touched dependency related code. Is there anything special about your client that I can use to reproduce? Browser version? platform? When you view the show_bug.cgi page, can you verify that the dependencies are properly listed in the text field when you click "edit"?


dkl

Comment 5

[David Lawrence [:dkl]]

(In reply to Ryan VanderMeulen from comment #3)
> This bug is causing dependencies to be cleared all over the place.

Are the others that you seeing being caused by the same account making changes or are others causing it as well?

dkl

Comment 6

[Alice0775 White]

Reproduced on Bug 273874  and Bug 717070.
And the dependencies are also duplicated when I click "edit".
Also reproduced with/without Logon.

Reproduced on
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0

Comment 7

[rsx11m]

Examples where dependencies were cleared: Bug 480393, bug 599615, bug 755898. Cleared dependencies where not doubled though when reinstated in a 2nd post.

Comment 8

[rsx11m]

Note that https://bugzilla.mozilla.org/show_activity.cgi?id=480393 shows all but the most recent changes duplicated in the history, in case it makes a difference (I don't see that with the other two example bugs mentioned, though).

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I just had this with quite a few bugs in product Calendar too, for example bug 756790. I had just opened the bug and there were no changes between me opening the bug and adding a comment (which cleared the dependencies).

Comment 10

[David Lawrence [:dkl]]

i will look at this some more around 2pm EST

dkl

Comment 11

[David Lawrence [:dkl]]

(In reply to Philipp Kewisch [:Fallen] (away until May 28th) from comment #9)
> I just had this with quite a few bugs in product Calendar too, for example
> bug 756790. I had just opened the bug and there were no changes between me
> opening the bug and adding a comment (which cleared the dependencies).

What was the bug id you saw this with? 

dkl

Comment 12

[David Lawrence [:dkl]]

(In reply to Alice0775 White from comment #6)
> Reproduced on Bug 273874  and Bug 717070.
> And the dependencies are also duplicated when I click "edit".
> Also reproduced with/without Logon.

Ok, I am able to observe the duplication of dependencies on the two bugs mentioned. I am still not seeing in the code where this is rendering the duplicates so there must be some duplication in the database itself that got there by mistake.

justdave, ashish, fox2mike, can any of you run the following query for me and post the results?

  SELECT dependson
    FROM dependencies
         INNER JOIN bugs ON dependencies.dependson = bugs.bug_id
         INNER JOIN bug_status ON bugs.bug_status = bug_status.value
   WHERE blocked = 273874
ORDER BY is_open DESC, dependson

I need to see if the duplication is there and then try to figure out how the code got it there in the first place.

dkl

Comment 13

[Dumitru Gherman [:dumitru]]

[root@tp-bugs01-slave01 ~]# mysql bugs < 756790.sql
dependson
700898
700898
715315
715315
725904
725904
715348
715348
721242
721242
721265
721265

Comment 14

[David Lawrence [:dkl]]

(In reply to Dumitru Gherman [:dumitru] from comment #13)
> [root@tp-bugs01-slave01 ~]# mysql bugs < 756790.sql
> dependson
> 700898
> 700898
> 715315
> 715315
> 725904
> 725904
> 715348
> 715348
> 721242
> 721242
> 721265
> 721265

Damn. Ok thanks. Now to see why the duplicates are getting added.

dkl

Comment 15

[Joe Sabash [:JoeS1]]

This does not appear to be dependent on the browser version used.
Just happened to me using Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20100101 Firefox/10.0.2

Comment 16

[Daniel C]

When was the last time that the production code was updated? What were the old and new revisions? Is this the correct list of changes? http://bzr.mozilla.org/bmo/4.0/changes

I'm currently avoiding changing any bugs' fields because dependencies seem to randomly disappear without me changing them and with no mid-air warning.

Comment 17

[:glob ✱]

(In reply to Daniel Cater from comment #16)
> When was the last time that the production code was updated?
> What were the old and new revisions? 

https://bugzilla.mozilla.org/cvs-update.log

> Is this the correct list of changes? http://bzr.mozilla.org/bmo/4.0/changes

yes.

Comment 18

[:glob ✱]

273874 is interesting; the dependency on 700898 was added 2012-01-04 and the bug was last updated 2012-05-01.  the database was correct as of the 2012-03-01.

it looks like something happened on 2012-05-19, i don't see any events earlier than this date.

Comment 19

[:glob ✱]

this was the result of a combination of database maintenance work and a missing uniqueness constraint on the dependencies table.

sheeri has removed the duplicate entries from that table.

i've filed bug 756946 to track updating the code and schema to add this missing constraint, as well as to fix the other two table which have been impacted (bugs_activity and profiles_activity).