Closed Bug 75682 Opened 24 years ago Closed 24 years ago

Code in areTheSameFileNames(...) should be cross-platform

Categories

(Core Graveyard :: Plug-ins, defect, P3)

x86
All
defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9.1

People

(Reporter: serhunt, Assigned: serhunt)

Details

Attachments

(1 file)

This is in nsPluginHostImpl.cpp. It uses backslashes in the path to file locations which is valid for Windows but not for other platforms.
Nominating 0.9.1 as this will cause multiple nsPluginTag objects for the same plugin be created during navigator.plugins.refresh. Accepting.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.1
Can a nsFileSpec or nsIFile be used instead be used instead?
If I am not mistaken one of those is deprecated. I'll try to look at it as soon as I can. May be we should lower its priority. I am trying to think of terrible things happening because of having multiple entries for the same plugin and cannot come up with any. Serge? From the other hand, the fix should be fairly simple and take no time if only to know the right way.
Attached patch first trySplinter Review
Peter, please review.
r=peterl
sr=attinasi - and, for the last comment, Win2K does not have case sensitive filenames.
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
verif that the patch was checked in
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: