756877 - Firefox cannot display images with bogus color profiles

Status: RESOLVED WORKSFORME

(Core :: Graphics: Color Management, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Attachment: Unable to decode this image.

http://4walled.cc/show-729990

Gives a black square in Firefox. Works correctly in IE, Chrome and Opera.

Windows Image Viewer also fails on it, so it may be corrupted or strange. Nevertheless, we're the only browser that can't display it.

Comment 1

[Mardeg]

Attachment: Screenshot of how the image renders in Amaya browser

Hope this helps pinpoint the anomaly.

Comment 2

[Justin Dolske [:Dolske]]

Works fine in OS X Preview, as well as in Firefox 12 with gfx.color_management.mode set to 0 (disabled).

(Looks like an otherwise normal RGB JPEG from a quick glance. Also, in both cases I mention the image looks fine -- no edge smearing as in attachment 625499 [details])

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Another example:
http://4walled.cc/show-740608

Comment 4

[Benoit Girard (:BenWa)]

Could be a regression of bug 752254. Is this nightly only?

Comment 5

[Gian-Carlo Pascutto [:gcp]]

It's broken already in:
http://hg.mozilla.org/mozilla-central/rev/357da346ceb7

Comment 6

[Gian-Carlo Pascutto [:gcp]]

Was already broken in Firefox 3.7:
http://hg.mozilla.org/mozilla-central/rev/b2f7bc2aa0bc

Comment 7

[Tony Payne]

This image has an A2B0 LUT but otherwise the color profile is "bogus". The image loads fine when color_management mode is set to 2. If you wanted this to work with color_management set to 1, you would need to add a check for bogus profile in image decoding and you would need to only short-circuit the bogus check when A2B0 exists and v4 is enabled. Since A2B0 is ignored unless v4 is enabled, it doesn't make sense to consider all profiles with A2B0 as valid.

Comment 8

[Benoit Girard (:BenWa)]

(In reply to Tony Payne from comment #7)

Thanks for investigating this.

Comment 9

[vulcain]

I confirm the bug on Linux x86_64 with Firefox 16.0.1

Comment 11

[Ashley Hale [:ahale]]

Out of the box this seems to work on Firefox 141 and probably has for some time.