Open Bug 756885 Opened 8 years ago Updated 4 years ago

test_bug624329.xul fails on OS X 10.7 and 10.8 and 10.9 and 10.10, where calling win.maximize() gives us a resize event when the window has barely changed size

Categories

(Core :: Widget: Cocoa, defect)

x86_64
macOS
defect
Not set

Tracking

()

People

(Reporter: philor, Unassigned)

References

Details

(Whiteboard: [leave open][qa-][tpi:-])

Attachments

(2 files, 2 obsolete files)

e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=11897967&tree=Firefox#error10

13726 INFO TEST-START | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul
13727 INFO TEST-INFO | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | must wait for load
13728 INFO TEST-INFO | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | must wait for focus
13729 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | window should be maximized - got 3, expected 1
13730 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | window inner width should have changed - 308 should not equal 300
13731 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | menu top 12 should be below click point 10
13732 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | menu top 12 should not be too far below click point 10
13733 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | menu left 300 should be left of click point 298
13734 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | menu right 791 should be right of click point 298
13735 INFO TEST-END | chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_bug624329.xul | finished in 1792ms

You've never seen it, because we started running tests on 10.7 last October but never bothered doing anything about the ones that were hidden because they were permaorange.
Attached patch bail early on 10.7 (obsolete) — Splinter Review
Attachment #625520 - Flags: review?(karlt)
Blocks: 700503
Comment on attachment 625520 [details] [diff] [review]
bail early on 10.7

Better idea will be better.
Attachment #625520 - Attachment is obsolete: true
Attachment #625520 - Flags: review?(karlt)
I'm not absolutely convinced this is better, since I see an "Intermittent TEST-UNEXPECTED-PASS" bug in my future, but it's certainly more correct.
Attachment #625554 - Flags: review?(karlt)
Bitter though I am about the window not being maximized for us, leaving it around until shutdown is probably not a great idea.
Attachment #625557 - Flags: review?(karlt)
Attachment #625554 - Attachment is obsolete: true
Attachment #625554 - Flags: review?(karlt)
Comment on attachment 625557 [details] [diff] [review]
bail a little better

Thanks!  If this turns out to be intermittent, feel free to disable the whole test (so long as doing so also prevents opening the window).
Attachment #625557 - Flags: review?(karlt) → review+
At least all that fumbling around gave me a better understanding of the issue:

The test needs the window against the right side of the screen, to open a context menu that will have to shift to the left, so it calls win.maximize().

On every other platform, when the listener gets a resize event, win.state == win.STATE_MAXIMIZED, and win.innerWidth is not only not 300, it's now substantially higher.

On 10.7, when the resize event fires, the window is not maximized, and innerWidth is only 308, not enough to shove it up against the right side of the screen, so the context menu doesn't have to shift to the left, so the test for it being off to the left fails since it's off to the right.

No longer blocks bug 700503, though, since it's disabled and thus green.
No longer blocks: 700503
Summary: test_bug624329.xul fails on OS X 10.7 → test_bug624329.xul fails on OS X 10.7, where calling win.maximize() gives us a resize event when the window has barely changed size
Whiteboard: [leave open]
Attached patch bail on 10.8 tooSplinter Review
Blocks: 786084
Summary: test_bug624329.xul fails on OS X 10.7, where calling win.maximize() gives us a resize event when the window has barely changed size → test_bug624329.xul fails on OS X 10.7 and 10.8, where calling win.maximize() gives us a resize event when the window has barely changed size
Hi, it's me again.

https://hg.mozilla.org/integration/mozilla-inbound/rev/43cb549c9f23
Summary: test_bug624329.xul fails on OS X 10.7 and 10.8, where calling win.maximize() gives us a resize event when the window has barely changed size → test_bug624329.xul fails on OS X 10.7 and 10.8 and 10.9, where calling win.maximize() gives us a resize event when the window has barely changed size
Hi, me again.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fe813bedca0
Summary: test_bug624329.xul fails on OS X 10.7 and 10.8 and 10.9, where calling win.maximize() gives us a resize event when the window has barely changed size → test_bug624329.xul fails on OS X 10.7 and 10.8 and 10.9 and 10.10, where calling win.maximize() gives us a resize event when the window has barely changed size
Whiteboard: [leave open][qa-] → [leave open][qa-][tpi:-]
You need to log in before you can comment on or make changes to this bug.