Closed Bug 756887 Opened 10 years ago Closed 10 years ago

Require.jsm should have support and tests for firebug/NetMonitor style modules

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 15

People

(Reporter: jwalker, Assigned: jwalker)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

Also the define statements in the tests should be updated to be more technically correct.
Attached patch Upload 1 (obsolete) — Splinter Review
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #625508 - Flags: review?(rcampbell)
Summary: Require.jsm should have tests for firebug/NetMonitor style modules → Require.jsm should have support and tests for firebug/NetMonitor style modules
Attached patch Upload 2Splinter Review
Test driven development at its finest - forgetting where the actual code was in my patch queue, so the tests test code that hasn't been committed yet. Promoting the code so the tests are in with the code. Duh.
Attachment #625508 - Attachment is obsolete: true
Attachment #625508 - Flags: review?(rcampbell)
Attachment #625581 - Flags: review?(rcampbell)
Blocks: NetMonitor
Blocks: 749396
No longer blocks: 749396
Blocks: 749397
Comment on attachment 625581 [details] [diff] [review]
Upload 2

okay!
Attachment #625581 - Flags: review?(rcampbell) → review+
https://tbpl.mozilla.org/?tree=Fx-Team&rev=7df3e6796d1f
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e27fa361af61
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.