Require.jsm should have support and tests for firebug/NetMonitor style modules

RESOLVED FIXED in Firefox 15

Status

P1
normal
RESOLVED FIXED
7 years ago
8 months ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 15
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

Also the define statements in the tests should be updated to be more technically correct.
Created attachment 625508 [details] [diff] [review]
Upload 1
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #625508 - Flags: review?(rcampbell)
Summary: Require.jsm should have tests for firebug/NetMonitor style modules → Require.jsm should have support and tests for firebug/NetMonitor style modules
Created attachment 625581 [details] [diff] [review]
Upload 2

Test driven development at its finest - forgetting where the actual code was in my patch queue, so the tests test code that hasn't been committed yet. Promoting the code so the tests are in with the code. Duh.
Attachment #625508 - Attachment is obsolete: true
Attachment #625508 - Flags: review?(rcampbell)
Attachment #625581 - Flags: review?(rcampbell)
No longer blocks: 749396
Comment on attachment 625581 [details] [diff] [review]
Upload 2

okay!
Attachment #625581 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/e27fa361af61
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.