Closed Bug 75691 Opened 22 years ago Closed 22 years ago
Implement new Attachment tree for message pane and compose window
This is a tracking bug. I've re-written the compose attachment tree widget to show document icons for each attachment you add. I've re-written the message pane's attachment button / menu popup to now be a tree widget listing the attachments. Here to, we now show the document icon associated with each attachment. It looks pretty cool! I'm sure we'll have some polish details to take care of to get it the way we want. This bug is to track the landing of these two changes.
this bug depends on landing moz-icon urls.
This will also fix bug 62699. :-)
Depends on: 62699
My hard drive crashed yesterday so I lost these changes and had to do them again =). Sorry for the delay. This patch contains the following: 1) CSS changes for classic and modern for the new tree widget in the message pane for attachments. 2) XUL and JS changes in nsMsgHdrViewOverlay to show attachments as a tree with the associated application icon using moz-icon urls. 3) Show the edit draft button 4) Re-implement save all attachments with the new message display. 4) Add a context menu on the attachment tree for open, save, print (not implemented) and save all. 5) Implement an attachment popup list under File / Attachments which is populated with the attachments for the currently displayed message. When you click on the attachment in this menu list, you get another menu popup where you can click on open save or save all.
This is awesome, super, peachy-keen. Nice work, Scott! To repay you, I'll let you win one UT match tomorrow night. Some comments on the patch: * Do you really need to add the separator and Save All item in FillAttachmentListPopup? You could just put them in XUL and use a dtd for "Save All" instead of needing a string bundle. When you clear the list, remove every node from 0 until you hit the separator. When you build the list, use popup.insertBefore(newItem, separator) instead of appendChild * I hate it when people criticize my patches for having tabs in them. With that said, I see tabs in your patch. Some extra suggestions: * it would be nice to show the icon in the attachments popup * since you're already building the attachments popup, it would be nice to show it in the collapsed header when you click on the attachments icon, rather than just expanding the header * it would be nice to allow multiple selection on the attachment tree and enable the open/save/print commands to act on all selected (especially save)
moving to 0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
this 2nd patch adds some feedback from hewitt. 1) adding moz-icons in the Attachment File menu popup. 2) adding the separator & Save All for this same menu popup into the xul instead of generating it dynamically so I don't need a string bundle. I don't know what he's talking about with regards to tabs. My editor doesn't insert tabs. I'm still blocked on landing all this stuff for a sr from hyatt on moz-icon urls. I'll keep pestering him. It's been a couple weeks....
we now have icons based on the content type of the attachment showing up in the message pane and in the compose window.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
I see icons on Mac for attachments (.jpg, .html, .eml) but I don't see any on Windows and linux. Is there something else I should do to see these. This is true for the Compose window when composing and Message pane when viewing.
I don't see them for Windows either.
that's because I didn't add moz-icon urls to the packaging file for windows. Debug builds have them =). Use tonights win32 release build from 5:30pm and you'll see them.
OK, now I see them on Windows 5-10 build 2001-05-10-06 (when I don't crash launching mail due to another bug). Now waiting for a linux 5-10 build
I don't see the icons on the linux 2001-05-10-15. Just found out from Scott that these aren't supported for linux. Verified.
Status: RESOLVED → VERIFIED
*** Bug 62699 has been marked as a duplicate of this bug. ***
Working for me now too. Scott, this is really nice! :-)
You need to log in before you can comment on or make changes to this bug.