75691 - Implement new Attachment tree for message pane and compose window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Scott MacGregor]

This is a tracking bug. 

I've re-written the compose attachment tree widget to show document icons for
each attachment you add. 

I've re-written the message pane's attachment button / menu popup to now be a
tree widget listing the attachments. Here to, we now show the document icon
associated with each attachment. 

It looks pretty cool!

I'm sure we'll have some polish details to take care of to get it the way we want. 

This bug is to track the landing of these two changes.

Comment 1

[Scott MacGregor]

this bug depends on landing moz-icon urls. 

Comment 2

[jglick]

This will also fix bug 62699.  :-)

Comment 3

[Scott MacGregor]

Attachment: Changes to themes and mailnews for new attachment disp. (plus other fixes)

Comment 4

[Scott MacGregor]

My hard drive crashed yesterday so I lost these changes and had to do them again
=). Sorry for the delay.

This patch contains the following:
1) CSS changes for classic and modern for the new tree widget in the message
pane for attachments.
2) XUL and JS changes in nsMsgHdrViewOverlay to show attachments as a tree with
the associated application icon using moz-icon urls.
3) Show the edit draft button
4) Re-implement save all attachments with the new message display.
4) Add a context menu on the attachment tree for open, save, print (not
implemented) and save all.
5) Implement an attachment popup list under File / Attachments which is
populated with the attachments for the currently displayed message. When you
click on the attachment in this menu list, you get another menu popup where you
can click on open save or save all.

Comment 5

[Joe Hewitt (gone)]

This is awesome, super, peachy-keen.  Nice work, Scott!  To repay you, I'll let
you win one UT match tomorrow night.

Some comments on the patch:
* Do you really need to add the separator and Save All item in
FillAttachmentListPopup? You could just put them in XUL and use a dtd for "Save
All" instead of needing a string bundle.  When you clear the list, remove every
node from 0 until you hit the separator.  When you build the list, use
popup.insertBefore(newItem, separator) instead of appendChild
* I hate it when people criticize my patches for having tabs in them.  With that
said, I see tabs in your patch.


Some extra suggestions:

* it would be nice to show the icon in the attachments popup
* since you're already building the attachments popup, it would be nice to show
it in the collapsed header when you click on the attachments icon, rather than
just expanding the header
* it would be nice to allow multiple selection on the attachment tree and enable
the open/save/print commands to act on all selected (especially save)

Comment 6

[scottputterman]

moving to 0.9.1

Comment 7

[Scott MacGregor]

Attachment: new changes to mailnews\base\resources\content

Comment 8

[Scott MacGregor]

this 2nd patch adds some feedback from hewitt.

1) adding moz-icons in the Attachment File menu popup.
2) adding the separator & Save All for this same menu popup into the xul instead
of generating it dynamically so I don't need a string bundle.

I don't know what he's talking about with regards to tabs. My editor doesn't
insert tabs.

I'm still blocked on landing all this stuff for a sr from hyatt on moz-icon
urls. I'll keep pestering him. It's been a couple weeks....

Comment 9

[Scott MacGregor]

we now have icons based on the content type of the attachment showing up in the
message pane and in the compose window. 

Comment 10

[esther]

I see icons on Mac for attachments (.jpg, .html, .eml) but I don't see any on 
Windows and linux.  Is there something else I should do to see these.  
This is true for the Compose window when composing and Message pane when 
viewing.

Comment 11

[jglick]

I don't see them for Windows either.

Comment 12

[Scott MacGregor]

that's because I didn't add moz-icon urls to the packaging file for windows.
Debug builds have them =).

Use tonights win32 release build from 5:30pm and you'll see them.

Comment 13

[esther]

OK, now I see them on Windows 5-10 build 2001-05-10-06 (when I don't crash 
launching mail due to another bug).  Now waiting for a linux 5-10 build 

Comment 14

[esther]

I don't see the icons on the linux 2001-05-10-15.  Just found out from Scott 
that these aren't supported for linux.  Verified.

Comment 15

[esther]

*** Bug 62699 has been marked as a duplicate of this bug. ***

Comment 16

[jglick]

Working for me now too.  Scott, this is really nice! :-)